Skip to content

Conversation

@hrntknr
Copy link
Member

@hrntknr hrntknr commented Aug 20, 2025

Summary

This PR adds comprehensive OIDC (OpenID Connect) provider support to mcp-auth-proxy, enabling authentication with any OIDC-compliant identity provider such as Keycloak, Auth0, Azure AD, and others.

Type of Change

  • feat: A new feature

Related Issues

Changes Made

  • Added new OIDC provider implementation in pkg/auth/oidc.go
  • Implemented configurable OIDC endpoints with automatic discovery
  • Added support for custom user ID field mapping using JSON pointer syntax
  • Added comprehensive CLI flags and environment variables for OIDC configuration:
    • OIDC_CONFIGURATION_URL: OIDC discovery endpoint
    • OIDC_CLIENT_ID / OIDC_CLIENT_SECRET: OAuth credentials
    • OIDC_SCOPES: Configurable OAuth scopes
    • OIDC_USER_ID_FIELD: JSON pointer to user identifier field
    • OIDC_PROVIDER_NAME: Display name for provider
    • OIDC_ALLOWED_USERS: Allowlist of authorized users
  • Updated README with detailed OIDC setup instructions and configuration examples
  • Added new GitHub Actions workflow for automated checks

Testing

The implementation follows the same patterns as existing GitHub OAuth provider and includes proper error handling and validation.

- Add OIDC provider implementation with configurable endpoints
- Support for custom user ID field mapping using JSON pointer
- Add comprehensive CLI flags and environment variables for OIDC configuration
- Update README with OIDC setup instructions and configuration options
- Include new GitHub Actions workflow for automated checks
Copilot AI review requested due to automatic review settings August 20, 2025 11:05
@codecov
Copy link

codecov bot commented Aug 20, 2025

Codecov Report

❌ Patch coverage is 0% with 135 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
pkg/auth/oidc.go 0.00% 82 Missing ⚠️
main.go 0.00% 38 Missing ⚠️
pkg/mcp-proxy/main.go 0.00% 15 Missing ⚠️

📢 Thoughts on this report? Let us know!

@hrntknr hrntknr merged commit f8edabe into main Aug 20, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants