Skip to content

[SIG-11508]: pivot and unpivot #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 10, 2021
Merged

[SIG-11508]: pivot and unpivot #2

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
33 changes: 32 additions & 1 deletion src/ast/query.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -319,6 +319,14 @@ pub enum TableFactor {
/// https://docs.snowflake.com/en/sql-reference/constructs/pivot.html
Pivot {
expr: Expr,
alias: Option<TableAlias>,
val: Ident,
pivot_vals: Vec<Expr>,
},
/// https://docs.snowflake.com/en/sql-reference/constructs/unpivot.html
Unpivot {
expr: Expr,
alias: Option<TableAlias>,
val: Ident,
pivot_vals: Vec<Expr>,
},
Expand Down Expand Up @@ -389,6 +397,25 @@ impl fmt::Display for TableFactor {
}
TableFactor::Pivot {
expr,
alias,
val,
pivot_vals,
} => {
write!(f, "({} FOR {} IN (", expr, val)?;
let mut delim = "";
for pivot_val in pivot_vals {
write!(f, "{}{}", delim, pivot_val)?;
delim = ", ";
}
write!(f, "))")?;
if let Some(alias) = alias {
write!(f, " AS {}", alias)?;
}
Ok(())
}
TableFactor::Unpivot {
expr,
alias,
val,
pivot_vals,
} => {
Expand All @@ -398,7 +425,11 @@ impl fmt::Display for TableFactor {
write!(f, "{}{}", delim, pivot_val)?;
delim = ", ";
}
write!(f, "))")
write!(f, "))")?;
if let Some(alias) = alias {
write!(f, " AS {}", alias)?;
}
Ok(())
}
TableFactor::NestedJoin(table_reference) => write!(f, "({})", table_reference),
}
Expand Down
3 changes: 3 additions & 0 deletions src/parser.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2631,6 +2631,7 @@ impl<'a> Parser<'a> {
alias.replace(outer_alias);
}
TableFactor::Pivot { .. } => unreachable!(),
TableFactor::Unpivot { .. } => unreachable!(),
TableFactor::NestedJoin(_) => unreachable!(),
};
}
Expand Down Expand Up @@ -2681,8 +2682,10 @@ impl<'a> Parser<'a> {
let pivot_vals = self.parse_comma_separated(Parser::parse_expr)?;
self.expect_token(&Token::RParen)?;
self.expect_token(&Token::RParen)?;
let alias = self.parse_optional_table_alias(keywords::RESERVED_FOR_TABLE_ALIAS)?;
Ok(TableFactor::Pivot {
expr,
alias,
val,
pivot_vals,
})
Expand Down