-
Notifications
You must be signed in to change notification settings - Fork 2
Implementation of Auth commands #179
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some suggestions:
- The message To authenticate, visit: https://auth.staging.signadot.com/activate?user_code=WXMK-ZDNB
would IMO be less confusing if it read
To authenticate, visit: https://auth.staging.signadot.com/activate?user_code=WXMK-ZDNB
and confirm the code: WXMK-ZDNB
since the page you direct to says "please confirm the code"
- I think the message
Error: No authentication found. Please either specify an API key through SIGNADOT_API_KEY env var/api_key field in ~/.signadot/config.yaml, or log in using 'auth login'
is too long for 1 line and that auth login
should be the first option
This is done in e04feb0.
I changed the order, now it reads like:
Not sure, how to make it shorter (and we have a similar error when the org is undefined). I will let you and @foxish define this. |
changed the auth error messages in b676c7f:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Depends on signadot/go-sdk#63.
This PR implements
signadot auth login
andsignadot auth logout
commands.E.g: