-
Notifications
You must be signed in to change notification settings - Fork 2
Multi-cluster RGs Implementation #207
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
I would change the |
} | ||
|
||
func (smr *SmartTestRun) Validate() error { | ||
c := 0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
probably renaming this var?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well.. I think this is a matter of taste. I named it like that because we already had this code:
Lines 221 to 231 in 422eed0
func (lp *LocalProxy) Validate() error { | |
c := 0 | |
if lp.Sandbox != "" { | |
c += 1 | |
} | |
if lp.RouteGroup != "" { | |
c += 1 | |
} | |
if lp.Cluster != "" { | |
c += 1 | |
} |
And I wanted it to look consistent.
if cluster != "" { | ||
return cluster | ||
} | ||
return "- (multi-cluster)" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would just return "(multi-cluster)"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done in 40bee4d.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
First, we don't easily have that info (we have the list of matching sandboxes, from where we could resolve the clusters involved). But second, it feels we are mixing meanings if we do that: in one case (regular RGs) the cluster is populated based on the spec, and in the other based on the status, which looks confusing to me. |
E.g.: