Skip to content

Conversation

daniel-de-vera
Copy link
Contributor

E.g.:

$ signadot routegroup apply -f - <<EOF
name: hotrod-multi-cluster
spec:
  match:
    all:
    - label:
        key: app
        value: hotrod
  endpoints:
  - name: frontend
    target: http://frontend.hotrod-devmesh.svc:8080
    cluster: test
EOF


$ signadot rg get hotrod-multi-cluster
Name:             hotrod-multi-cluster
Routing Key:      kwxt78pbldssy
Cluster:          - (multi-cluster)
Created:          Fri, 29 Aug 2025 15:07:12 -03 (2 days ago)
TTL:              - (forever)
Dashboard page:   https://app.signadot.com
Status:           Ready (RoutingReady: routing is ready for all workloads in all sandboxes)

ROUTEGROUP ENDPOINT   CLUSTER   TARGET                                    URL
frontend              test      http://frontend.hotrod-devmesh.svc:8080   http://frontend--hotrod-multi-cluster.localhost.signadot.com:8086


$ signadot rg list
NAME                   ROUTING KEY     CLUSTER             CREATED        STATUS   READY SANDBOXES
hotrod-main-xrc        87p1n290yv7w4   xrc-test            9 months ago   Ready    0/0
hotrod                 jvrtrkzg1sdzg   test                7 months ago   Ready    1/1
hotrod-multi-cluster   kwxt78pbldssy   - (multi-cluster)   3 days ago     Ready    1/1

@davixcky
Copy link
Contributor

davixcky commented Sep 1, 2025

I would change the - (multi-cluster and use something like clusterA, clusterB

}

func (smr *SmartTestRun) Validate() error {
c := 0
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

probably renaming this var?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well.. I think this is a matter of taste. I named it like that because we already had this code:

func (lp *LocalProxy) Validate() error {
c := 0
if lp.Sandbox != "" {
c += 1
}
if lp.RouteGroup != "" {
c += 1
}
if lp.Cluster != "" {
c += 1
}

And I wanted it to look consistent.

if cluster != "" {
return cluster
}
return "- (multi-cluster)"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would just return "(multi-cluster)"

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done in 40bee4d.

Copy link
Member

@scott-cotton scott-cotton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@daniel-de-vera
Copy link
Contributor Author

I would change the - (multi-cluster and use something like clusterA, clusterB

First, we don't easily have that info (we have the list of matching sandboxes, from where we could resolve the clusters involved). But second, it feels we are mixing meanings if we do that: in one case (regular RGs) the cluster is populated based on the spec, and in the other based on the status, which looks confusing to me.

@daniel-de-vera daniel-de-vera merged commit 0c6e35c into main Sep 2, 2025
@daniel-de-vera daniel-de-vera deleted the multi-cluster-rgs branch September 2, 2025 17:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants