feature branch for request middlewares #211
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- allow exp-middleware: in sandbox spec - support free revtuns
Comment on lines
101
to
102
| case "Revtun": | ||
| return "revtun", nil |
There was a problem hiding this comment.
@scott-cotton, shouldn't this be Forward?
* add skeleton for local override * add sandbox builder * use sandbox builder to add middleware * Fix merge * apply go-mod-tidy * feat: add refresh api config and missing flags * refactor: move waitforsandbox readiness to separate function * feat: make sandbox apply use new utility + sandbox builder * feat: add helpers in sandbox builder that allows to set machine id and others fields * feat: complete create, list and delete methods for override * feat: move sbmg logic to sbmgr pacakge * fix: build * fix logic in sandbox builder for removing override * fix pending PR comments * fix logic for getting overrides * add examples for other commands and clear the local logic for override * redo poll enum
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.