Skip to content

Renamed apiEndpoint to just url #18

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 3, 2019
Merged

Renamed apiEndpoint to just url #18

merged 1 commit into from
Oct 3, 2019

Conversation

digitaljohn
Copy link

Which issue, if any, is this issue related to?

n/a

Is there anything in the PR that needs further explanation?

Simplified the API. apiEndpoint is now just url.

@digitaljohn digitaljohn requested a review from nattog October 3, 2019 12:56
@digitaljohn digitaljohn self-assigned this Oct 3, 2019
@digitaljohn digitaljohn added documentation Improvements or additions to documentation enhancement New feature or request labels Oct 3, 2019
nattog
nattog approved these changes Oct 3, 2019
View reviewed changes
Copy link
Contributor

@nattog nattog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@digitaljohn digitaljohn merged commit 2a28bcc into master Oct 3, 2019
@digitaljohn digitaljohn deleted the apiendpoint-rename branch October 3, 2019 13:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@nattog nattog nattog approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@digitaljohn digitaljohn

Labels

documentation Improvements or additions to documentation enhancement New feature or request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@digitaljohn @nattog