Skip to content

Conversation

MichaelMcDonnell
Copy link

@MichaelMcDonnell MichaelMcDonnell commented Mar 4, 2021

First time contributor checklist

Contributor checklist

  • Motorola G7, Android 10
  • Virtual device Pixel_3a_API_30_x86, Android 11
  • My contribution is fully baked and ready to be merged as is
  • I ensure that all the open issues my contribution fixes are mentioned in the commit message of my first commit using the Fixes #1234 syntax

Description

This change adds an option to restrict calls from using mobile data. My wife
experienced a video call using 750 MB of data even though she was on WiFI. It
needs to be controllable in case you are on a metered plan since it might
otherwise make the call very expensive. My wife almost uninstalled Signal
because of this, but I got her to stay by promising I would fix it.

This change depends on my changes made to RingRTC (see signalapp/ringrtc#26). You need to make sure you have the right version of RingRTC. This fixes #8529

This change adds an option to restrict calls from using mobile data. My wife
experienced a video call using 750 MB of data even though she was on WiFI. It
needs to be controllable in case you are on a metered plan since it might
otherwise make the call very expensive. My wife almost uninstalled Signal
because of this, but I got her to stay by promising I would fix it.

This change depends on my changes made to RingRTC. You need to make sure you
have the right version of RingRTC.
@MichaelMcDonnell
Copy link
Author

MichaelMcDonnell commented Mar 4, 2021

The build failure is expected. It depends on RingRTC being updated. It should pass after that.

@hyakujon
Copy link

This ought to have been sorted when first reported. We also had our whole month's data used up on one video call despite our WiFi being on, 2m away, with a full strength connection and Video unchecked in Signal's mobile data settings. We're uninstalling Signal.

@stale
Copy link

stale bot commented Jan 25, 2022

Is this still relevant? If so, what is blocking it? Is there anything you can do to help move it forward?

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

@stale stale bot added the wontfix label Jan 25, 2022
@MichaelMcDonnell
Copy link
Author

To stalebot, I believe it is still relevant but the team at Signal have not had the time to thoroughly evaluate this change yet. That's at least what I've last heard.

@stale stale bot removed the wontfix label Jan 26, 2022
@stale
Copy link

stale bot commented Mar 27, 2022

Is this still relevant? If so, what is blocking it? Is there anything you can do to help move it forward?

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

@stale stale bot added the wontfix label Mar 27, 2022
@stale
Copy link

stale bot commented Apr 3, 2022

This issue has been closed due to inactivity.

@stale stale bot closed this Apr 3, 2022
@KiaraGrouwstra
Copy link

reopen

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Voice/Videocall - Mobile data used even if WiFi is available

3 participants