This repository was archived by the owner on Jan 11, 2023. It is now read-only.
Update dependencies; update README.md #34
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bgola-signalfx
requested review from
jkawecki-signalfx,
owais,
piotr-signalfx and
seonsfx
owais
approved these changes
Oct 26, 2020
| signalFxLambda.helper.sendCloudWatchEvent(event); | ||
| callback(null, 'Done'); |
Contributor
There was a problem hiding this comment.
Why was .then removed? Wouldn't this possibly result in the event being lost if the function stopped before the event was exported successfully?
| // to transform & forward CloudWatch event: | ||
| await signalFxLambda.helper.sendCloudWatchEvent(event); | ||
| signalFxLambda.helper.sendCloudWatchEvent(event); |
Contributor
There was a problem hiding this comment.
same comment as above. If we don't wait for the function to finish exporting, there is no guarantee the data will actually be reported as function may exit and execution may be stopped before the metrics lib has a chance to complete the export.
|
|
||
| This way multiple send operations may run concurrently without blocking your lambda handler code. | ||
|
|
||
| You can still await any of those promises if your use case forces you to do so. |
Contributor
There was a problem hiding this comment.
OK. This answers my questions above :)
Contributor
Author
There was a problem hiding this comment.
Great, thanks! :)
piotr-signalfx
approved these changes
Oct 27, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Key changes: