Improve kms key validations and error messages for awskms

[hectorj2f]

Summary

closes #523

Release Note

Improve kms key validations and error messages for awskms

Documentation

[mattmoor]

Does this address the confusing error when someone uses awskms://{arn} instead of awskms:///{arn}?

Otherwise this looks incredibly detailed, so thanks for the better validation!

[hectorj2f]

Does this address the confusing error when someone uses awskms://{arn} instead of awskms:///{arn}?

I added a specific use case for awskms://{arn} which is invalid but I agree we needed a better error message for this particular scenario.

[hectorj2f]

I added the last change here a4d61eb to ease the review.

[codecov-commenter]

Codecov Report

Merging #524 (a4d61eb) into main (33ed498) will decrease coverage by 0.92%.
The diff coverage is 3.92%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@            Coverage Diff             @@
##             main     #524      +/-   ##
==========================================
- Coverage   56.21%   55.30%   -0.92%     
==========================================
  Files          42       42              
  Lines        4454     4459       +5     
==========================================
- Hits         2504     2466      -38     
- Misses       1747     1792      +45     
+ Partials      203      201       -2     

Impacted Files	Coverage Δ
pkg/apis/policy/common/validation.go	17.46% <0.00%> (-61.12%)	⬇️
...s/policy/v1alpha1/clusterimagepolicy_validation.go	92.85% <100.00%> (+0.54%)	⬆️
...is/policy/v1beta1/clusterimagepolicy_validation.go	94.95% <100.00%> (+0.72%)	⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.