Skip to content

Improve paginated request #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 21, 2025
Merged

Improve paginated request #4

merged 2 commits into from
Nov 21, 2025

Conversation

@jason-jackson
Copy link
Contributor

@jason-jackson jason-jackson commented Nov 20, 2025

Changed

  • Don't fail if missing paginator in params
  • Use titleCase for function names

@jason-jackson jason-jackson requested a review from a team as a code owner November 20, 2025 23:10
@jason-jackson jason-jackson requested review from briskt, ethancanne, forevermatt and mtompset and removed request for a team November 20, 2025 23:10
@jason-jackson jason-jackson merged commit 5a0ccba into main Nov 21, 2025
@jason-jackson jason-jackson deleted the improve-paginated-request branch November 21, 2025 03:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@briskt briskt briskt approved these changes

@forevermatt forevermatt Awaiting requested review from forevermatt forevermatt is a code owner automatically assigned from sil-org/js-devs

@mtompset mtompset Awaiting requested review from mtompset mtompset is a code owner automatically assigned from sil-org/js-devs

@ethancanne ethancanne Awaiting requested review from ethancanne ethancanne is a code owner automatically assigned from sil-org/js-devs

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@jason-jackson @briskt