GHCR image push-postgresql-backup-restore #13
Conversation
Update backup repo images to push their docker image to GHCR Packages registry
Update backup repo images to push their docker image to GHCR Packages registry
|
@Praveenraj-K Thanks for putting together a PR for this. I've added the developers for review. |
briskt
left a comment
briskt
left a comment
There was a problem hiding this comment.
Looks great! I believe just one change is needed, which is to include version tags.
| branches: | ||
| - main |
There was a problem hiding this comment.
| branches: | |
| - main | |
| branches: [ 'main' ] | |
| tags: [ '*' ] |
I think this needs to include tags, otherwise we won't get image tags like 1.0.0.
| type=ref,event=branch # Tag with branch name | ||
| type=raw,value=latest,enable=${{ github.ref == format('refs/heads/{0}', 'main') }} |
There was a problem hiding this comment.
| type=ref,event=branch # Tag with branch name | |
| type=raw,value=latest,enable=${{ github.ref == format('refs/heads/{0}', 'main') }} | |
| type=semver,pattern={{version}} | |
| type=semver,pattern={{major}}.{{minor}} | |
| type=semver,pattern={{major}} | |
| type=ref,event=branch # Tag with branch name | |
| type=raw,value=latest,enable=${{ github.ref == format('refs/heads/{0}', 'main') }} |
We have only recently started adding semver tags. Previously, we would simply use type=ref,event=tag.
There was a problem hiding this comment.
Noted, Thanks Steve. I'll make the changes for the other the code so that it will be tagged by version's, instead of the branch. :)
udpated the branch and version tags
|
@Praveenraj-K, did you mean to merge this PR? It looks like it was closed without merging. |
Ahh, I see. It was replaced by #14. |
4 participants
-Pushing the images in both Docker Hub & GitHub Container Registry "GHCR.io"
-Only initiate when there is a commit in the main branch using the workflow trigger.