Skip to content

Conversation

@briskt
Copy link
Contributor

@briskt briskt commented Dec 1, 2025

Add --quiet to the second aws s3 cp command (copy to B2) and flip the order of ${MYNAME} and ${level} to make the log lines even more tidy. MYNAME is always the same length, but level can be different lengths.

and flip the order of `${MYNAME}` and `${level}` to make the log lines even more tidy. MYNAME is always the same length, but level can be different lengths.
@briskt briskt requested review from a team, Praveenraj-K, ethancanne, forevermatt and jason-jackson and removed request for a team December 1, 2025 03:13
Copy link
Contributor

@jason-jackson jason-jackson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine to me, do we reference logs in any of our DR documentation that needs to be changed?

@briskt
Copy link
Contributor Author

briskt commented Dec 1, 2025

Looks fine to me, do we reference logs in any of our DR documentation that needs to be changed?

I doubt it. The information is pretty useless in a log context, especially since @Praveenraj-K did a great job of adding other INFO log entries.

Here's an actual example:

Completed 1.0 MiB/18.5 MiB (3.7 MiB/s) with 1 file(s) remaining
Completed 2.0 MiB/18.5 MiB (5.0 MiB/s) with 1 file(s) remaining
Completed 3.0 MiB/18.5 MiB (7.0 MiB/s) with 1 file(s) remaining
Completed 4.0 MiB/18.5 MiB (6.6 MiB/s) with 1 file(s) remaining
Completed 4.5 MiB/18.5 MiB (6.7 MiB/s) with 1 file(s) remaining
Completed 5.5 MiB/18.5 MiB (7.5 MiB/s) with 1 file(s) remaining
Completed 6.5 MiB/18.5 MiB (8.2 MiB/s) with 1 file(s) remaining
Completed 7.5 MiB/18.5 MiB (9.2 MiB/s) with 1 file(s) remaining
Completed 8.5 MiB/18.5 MiB (10.1 MiB/s) with 1 file(s) remaining
Completed 9.5 MiB/18.5 MiB (11.0 MiB/s) with 1 file(s) remaining
Completed 10.5 MiB/18.5 MiB (11.8 MiB/s) with 1 file(s) remaining
Completed 11.5 MiB/18.5 MiB (12.8 MiB/s) with 1 file(s) remaining
Completed 12.5 MiB/18.5 MiB (13.3 MiB/s) with 1 file(s) remaining
Completed 13.5 MiB/18.5 MiB (13.9 MiB/s) with 1 file(s) remaining
Completed 14.5 MiB/18.5 MiB (14.8 MiB/s) with 1 file(s) remaining
Completed 15.5 MiB/18.5 MiB (15.2 MiB/s) with 1 file(s) remaining
Completed 16.5 MiB/18.5 MiB (15.8 MiB/s) with 1 file(s) remaining
Completed 17.5 MiB/18.5 MiB (16.3 MiB/s) with 1 file(s) remaining
Completed 18.5 MiB/18.5 MiB (16.7 MiB/s) with 1 file(s) remaining
upload: ./cover.sql.gz to s3://cover-prod-backups/cover.sql.gz

And the INFO log line that comes after it:

[2025-12-01 03:00:26] INFO: postgresql-backup-restore: Copy backup to Backblaze B2 bucket cover-prod-backups of cover completed in 2 seconds.

@briskt briskt merged commit 3c0eb67 into main Dec 1, 2025
@briskt briskt deleted the more-quiet branch December 1, 2025 04:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants