refactor router to reduce duplication and remove an external dependency #130
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
briskt
requested review from
devon-sil,
ethancanne and
hobbitronics
and removed request for
a team
but not for http server, and I unfortunately based router on the http server. Oops.
|
Contributor
jason-jackson
left a comment
jason-jackson
left a comment
There was a problem hiding this comment.
Not verified everything, hence just comments.
jason-jackson
approved these changes
Sep 17, 2025
Comment on lines
+180
to
182
| err := fmt.Errorf("%s path parameter not provided to DeleteCredential, path: %s", IDParam, r.URL.Path) | ||
| jsonResponse(w, err, http.StatusBadRequest) | ||
| log.Printf("%s\n", err) |
Contributor
There was a problem hiding this comment.
I don't think we want/need the path as part of the bad request response, I'd suggest just adding it to the log. Also given that it's passing the path now, should it also be sanitized as well? Actually, since it is "" here the path will always be /webauthn/credential// (or whatever), probably not even worth logging.
Suggested change
| err := fmt.Errorf("%s path parameter not provided to DeleteCredential, path: %s", IDParam, r.URL.Path) | |
| jsonResponse(w, err, http.StatusBadRequest) | |
| log.Printf("%s\n", err) | |
| err := fmt.Errorf("%s path parameter not provided to DeleteCredential", IDParam) | |
| jsonResponse(w, err, http.StatusBadRequest) | |
| log.Println(err) |
Contributor
Author
There was a problem hiding this comment.
Don't you mean that the error check could be removed since (I assume) ServeMux guarantees a non-zero path param?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.