Misc cleanup #131
Merged
Misc cleanup #131
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
briskt
requested review from
devon-sil,
ethancanne and
hobbitronics
and removed request for
a team
forevermatt
approved these changes
Sep 16, 2025
|
jason-jackson
approved these changes
Sep 17, 2025
| err := bcrypt.CompareHashAndPassword([]byte(k.HashedSecret), []byte(given)) | ||
| if err != nil { | ||
| return err | ||
| return fmt.Errorf("hash does not match plaintext (hash: %s) (plaintext: %v...): %w", |
Contributor
There was a problem hiding this comment.
Alternatively (I'm fine with current):
Suggested change
| return fmt.Errorf("hash does not match plaintext (hash: %s) (plaintext: %v...): %w", | |
| return fmt.Errorf("hash `%s` does not match plaintext `%v...`: %w", |
| user, err := mfa.AuthenticateRequest(r) | ||
| if err != nil { | ||
| http.Error(w, fmt.Sprintf("unable to authenticate request: %s", err), http.StatusUnauthorized) | ||
| log.Printf("unable to authenticate request: %s", err) |
Contributor
There was a problem hiding this comment.
Suggested change
| log.Printf("unable to authenticate request: %s", err) | |
| log.Println("unable to authenticate request:", err) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed