Skip to content

Conversation

@briskt
Copy link
Contributor

@briskt briskt commented Nov 3, 2025

IDP-1726 serverless-mfa-api-go does not include key ID in response


Added

  • Return key ID (and metadata) from the CreateKey request.

Fixed

  • Fixed the build workflow to push images on git tags.

Changed

  • Require authentication by x-mfa-apikey and x-mfa-apisecret for both /api-key endpoints. This may be a breaking change if these endpoints are in an automated workflow. Since these are generally not used for production and are rarely-used endpoints, no major version bump is necessary.

@briskt briskt requested review from a team as code owners November 3, 2025 06:28
@briskt briskt requested review from Praveenraj-K, ethancanne, hobbitronics and jason-jackson and removed request for a team November 3, 2025 06:28
@sonarqubecloud
Copy link

sonarqubecloud bot commented Nov 4, 2025

Copy link

@hobbitronics hobbitronics left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me and issue seems to be resolved.

@briskt briskt merged commit 0c0092a into main Nov 4, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants