remove CORS middleware #61
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CORS shouldn't be needed since the server is called directly by the ID Broker, not using XHR requests in a browser. If I am wrong and it is called in an XHR request, then the CORS Access-Control-Allow-Origin should be set to a specific value and not simply the origin value in the request header.
forevermatt
approved these changes
Aug 28, 2023
Contributor
forevermatt
left a comment
forevermatt
left a comment
There was a problem hiding this comment.
Looks fine to me (and conceptually, I agree that this shouldn't need CORS), I'm just not very proficient at the little syntax/implementation details.
jason-jackson
approved these changes
Aug 28, 2023
Contributor
jason-jackson
left a comment
jason-jackson
left a comment
There was a problem hiding this comment.
If I'm not mistaken, the lambda never used the CORS middleware anyway, just the server app, which also looks like it never used it either.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CORS shouldn't be needed since the server is called directly by the ID Broker, not using XHR requests in a browser. If I am wrong and it is called in an XHR request, then the CORS Access-Control-Allow-Origin should be set to a specific value and not simply the origin value in the request header.