Skip to content

Make no entry selected translation respect current view #1719

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 4, 2025
Merged

Make no entry selected translation respect current view #1719

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
754ad58
Make no entry selected translation respect current view
myieye Jun 2, 2025
7a89974
Prevent focus-ring cut-off
myieye Jun 2, 2025
b87c952
Update i18n
myieye Jun 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
47 changes: 42 additions & 5 deletions frontend/viewer/src/locales/en.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -112,6 +112,18 @@
"translation": "🤷 nothing here",
"obsolete": true
},
"fhKYsI": {
"message": "a word",
"placeholders": {},
"comments": [],
"origin": [
[
"src/project/browse/BrowseView.svelte",
108
]
],
"translation": "a word"
},
"uyJsf6": {
"message": "About",
"placeholders": {},
Expand Down Expand Up @@ -260,6 +272,18 @@
],
"translation": "ago"
},
"iPthvs": {
"message": "an entry",
"placeholders": {},
"comments": [],
"origin": [
[
"src/project/browse/BrowseView.svelte",
108
]
],
"translation": "an entry"
},
"ZYimak": {
"message": "Application version",
"placeholders": {},
Expand Down Expand Up @@ -989,7 +1013,7 @@
"origin": [
[
"src/project/browse/BrowseView.svelte",
64
67
]
],
"translation": "Headword"
Expand Down Expand Up @@ -1093,7 +1117,7 @@
"origin": [
[
"src/project/browse/BrowseView.svelte",
66
69
]
],
"translation": "List mode"
Expand Down Expand Up @@ -1568,7 +1592,7 @@
"origin": [
[
"src/project/browse/BrowseView.svelte",
79
82
]
],
"translation": "Preview"
Expand Down Expand Up @@ -1706,6 +1730,18 @@
],
"translation": "Select {0}"
},
"bbTYV2": {
"message": "Select {0} to view details",
"placeholders": {},
"comments": [],
"origin": [
[
"src/project/browse/BrowseView.svelte",
108
]
],
"translation": "Select {0} to view details"
},
"GzkNiw": {
"message": "Select an entry to view details",
"placeholders": {},
Expand All @@ -1716,7 +1752,8 @@
105
]
],
"translation": "Select an entry to view details"
"translation": "Select an entry to view details",
"obsolete": true
},
"mEtszZ": {
"message": "Semantic domains",
Expand Down Expand Up @@ -1846,7 +1883,7 @@
"origin": [
[
"src/project/browse/BrowseView.svelte",
75
78
]
],
"translation": "Simple"
Expand Down
47 changes: 42 additions & 5 deletions frontend/viewer/src/locales/es.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -112,6 +112,18 @@
"translation": "",
"obsolete": true
},
"fhKYsI": {
"message": "a word",
"placeholders": {},
"comments": [],
"origin": [
[
"src/project/browse/BrowseView.svelte",
108
]
],
"translation": ""
},
"uyJsf6": {
"message": "About",
"placeholders": {},
Expand Down Expand Up @@ -260,6 +272,18 @@
],
"translation": ""
},
"iPthvs": {
"message": "an entry",
"placeholders": {},
"comments": [],
"origin": [
[
"src/project/browse/BrowseView.svelte",
108
]
],
"translation": ""
},
"ZYimak": {
"message": "Application version",
"placeholders": {},
Expand Down Expand Up @@ -989,7 +1013,7 @@
"origin": [
[
"src/project/browse/BrowseView.svelte",
64
67
]
],
"translation": ""
Expand Down Expand Up @@ -1093,7 +1117,7 @@
"origin": [
[
"src/project/browse/BrowseView.svelte",
66
69
]
],
"translation": ""
Expand Down Expand Up @@ -1568,7 +1592,7 @@
"origin": [
[
"src/project/browse/BrowseView.svelte",
79
82
]
],
"translation": ""
Expand Down Expand Up @@ -1706,6 +1730,18 @@
],
"translation": ""
},
"bbTYV2": {
"message": "Select {0} to view details",
"placeholders": {},
"comments": [],
"origin": [
[
"src/project/browse/BrowseView.svelte",
108
]
],
"translation": ""
},
"GzkNiw": {
"message": "Select an entry to view details",
"placeholders": {},
Expand All @@ -1716,7 +1752,8 @@
105
]
],
"translation": ""
"translation": "",
"obsolete": true
},
"mEtszZ": {
"message": "Semantic domains",
Expand Down Expand Up @@ -1846,7 +1883,7 @@
"origin": [
[
"src/project/browse/BrowseView.svelte",
75
78
]
],
"translation": ""
Expand Down
47 changes: 42 additions & 5 deletions frontend/viewer/src/locales/fr.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -112,6 +112,18 @@
"translation": "",
"obsolete": true
},
"fhKYsI": {
"message": "a word",
"placeholders": {},
"comments": [],
"origin": [
[
"src/project/browse/BrowseView.svelte",
108
]
],
"translation": ""
},
"uyJsf6": {
"message": "About",
"placeholders": {},
Expand Down Expand Up @@ -260,6 +272,18 @@
],
"translation": ""
},
"iPthvs": {
"message": "an entry",
"placeholders": {},
"comments": [],
"origin": [
[
"src/project/browse/BrowseView.svelte",
108
]
],
"translation": ""
},
"ZYimak": {
"message": "Application version",
"placeholders": {},
Expand Down Expand Up @@ -989,7 +1013,7 @@
"origin": [
[
"src/project/browse/BrowseView.svelte",
64
67
]
],
"translation": ""
Expand Down Expand Up @@ -1093,7 +1117,7 @@
"origin": [
[
"src/project/browse/BrowseView.svelte",
66
69
]
],
"translation": ""
Expand Down Expand Up @@ -1568,7 +1592,7 @@
"origin": [
[
"src/project/browse/BrowseView.svelte",
79
82
]
],
"translation": ""
Expand Down Expand Up @@ -1706,6 +1730,18 @@
],
"translation": ""
},
"bbTYV2": {
"message": "Select {0} to view details",
"placeholders": {},
"comments": [],
"origin": [
[
"src/project/browse/BrowseView.svelte",
108
]
],
"translation": ""
},
"GzkNiw": {
"message": "Select an entry to view details",
"placeholders": {},
Expand All @@ -1716,7 +1752,8 @@
105
]
],
"translation": ""
"translation": "",
"obsolete": true
},
"mEtszZ": {
"message": "Semantic domains",
Expand Down Expand Up @@ -1846,7 +1883,7 @@
"origin": [
[
"src/project/browse/BrowseView.svelte",
75
78
]
],
"translation": ""
Expand Down
7 changes: 5 additions & 2 deletions frontend/viewer/src/project/browse/BrowseView.svelte
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,10 @@
import {Tabs, TabsList, TabsTrigger} from '$lib/components/ui/tabs';
import {Button} from '$lib/components/ui/button';
import {QueryParamState} from '$lib/utils/url.svelte';
import {pt} from '$lib/views/view-text';
import {useCurrentView} from '$lib/views/view-service';

const currentView = useCurrentView();
const dialogsService = useDialogsService();
const selectedEntryId = new QueryParamState({key: 'entryId', allowBack: true, replaceOnDefaultValue: true});
const defaultLayout = [30, 70] as const; // Default split: 30% for list, 70% for details
Expand Down Expand Up @@ -102,10 +105,10 @@
defaultSize={defaultLayout[1]} collapsible collapsedSize={0} minSize={15}>
{#if !selectedEntryId.current}
<div class="flex items-center justify-center h-full text-muted-foreground text-center m-2">
<p>{$t`Select an entry to view details`}</p>
<p>{$t`Select ${pt($t`an entry`, $t`a word`, $currentView)} to view details`}</p>
</div>
{:else}
<div class="md:p-4 md:pl-6 h-full">
<div class="md:p-4 md:pl-4 h-full">
<EntryView
entryId={selectedEntryId.current}
onClose={() => (selectedEntryId.current = '')}
Expand Down
8 changes: 5 additions & 3 deletions frontend/viewer/src/project/browse/EntryView.svelte
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,16 +90,18 @@
</div>
</div>
{#if dictionaryPreview === 'sticky'}
<div class="md:pr-2">
<div class="md:px-2">
{@render preview(entry)}
</div>
{/if}
</header>
<ScrollArea bind:viewportRef={entryScrollViewportRef} class={cn('grow md:pr-2', !$viewSettings.showEmptyFields && 'hide-unused')}>
{#if dictionaryPreview === 'show'}
{@render preview(entry)}
<div class="md:pl-2">
{@render preview(entry)}
</div>
{/if}
<div class="max-md:p-2 md:pr-2">
<div class="max-md:p-2 md:px-2">
<EntryEditor bind:ref={editorRef} {entry} {readonly} {...entryPersistence.entryEditorProps} />
</div>
</ScrollArea>
Expand Down
Loading