Update to use available sdk on gha-runner window-2025 #2005
Conversation
📝 WalkthroughWalkthroughUpdated the Windows SDK version in the GitHub Actions workflow for MSIX bundling from 10.0.19041.0 to 10.0.26100.0 by changing the SdkVersion assignment, thereby altering the sdkToolsPath and referenced SDK. No other logic or control flow changes. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Poem
Pre-merge checks and finishing touches❌ Failed checks (1 inconclusive)
✅ Passed checks (2 passed)
✨ Finishing touches🧪 Generate unit tests
Tip 👮 Agentic pre-merge checks are now available in preview!Pro plan users can now enable pre-merge checks in their settings to enforce checklists before merging PRs.
Please see the documentation for more information. Example: reviews:
pre_merge_checks:
custom_checks:
- name: "Undocumented Breaking Changes"
mode: "warning"
instructions: |
Pass/fail criteria: All breaking changes to public APIs, CLI flags, environment variables, configuration keys, database schemas, or HTTP/GraphQL endpoints must be documented in the "Breaking Change" section of the PR description and in CHANGELOG.md. Exclude purely internal or private changes (e.g., code not exported from package entry points or explicitly marked as internal).Please share your feedback with us on this Discord post. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
The latest updates on your projects. Learn more about Argos notifications ↗︎
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (2)
.github/workflows/fw-lite.yaml (2)
320-324: Make SDK discovery dynamic and prefer x64 tools.Hard‑coding
10.0.26100.0andx86is brittle and will break when the image rotates or if that SDK isn’t installed. Resolve the newest installed Windows 10 SDK at runtime and use the native architecture (x64 on GHA). Also, invoke MakeAppx via its full path.Apply this diff:
- $SdkVersion = '10.0.26100.0' - $Architecture = 'x86' - $sdkToolsPath = Join-Path -Path 'C:\Program Files (x86)\Windows Kits\10\bin' -ChildPath $SdkVersion -AdditionalChildPath $Architecture - $env:Path += ";$sdkToolsPath" + $kitRoot = 'C:\Program Files (x86)\Windows Kits\10\bin' + $arch = if ([Environment]::Is64BitOperatingSystem) { 'x64' } else { 'x86' } + $sdk = Get-ChildItem -Path $kitRoot -Directory | + Where-Object { Test-Path (Join-Path $_.FullName $arch) } | + Sort-Object Name -Descending | Select-Object -First 1 + if (-not $sdk) { throw "No Windows 10 SDK found under $kitRoot" } + $sdkToolsPath = Join-Path $sdk.FullName $arch + $makeAppx = Join-Path $sdkToolsPath 'MakeAppx.exe' + if (-not (Test-Path $makeAppx)) { throw "MakeAppx.exe not found at $makeAppx" }And update the invocation below to use the resolved path:
& $makeAppx bundle /v /bv ${{ needs.build-and-test.outputs.semver-version }}.1 /d . /p ../sign/FwLiteMaui.msixbundle
285-301: Optional: Pin the runner if you rely on a specific SDK.If you must use a particular SDK version, consider pinning
runs-onto the image that guarantees it (e.g.,windows-2025) or add a matrix fallback to older SDKs. Otherwise, keep dynamic discovery as above.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
.github/workflows/fw-lite.yaml(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (3)
- GitHub Check: frontend
- GitHub Check: Build FW Lite and run tests
- GitHub Check: frontend-component-unit-tests
🔇 Additional comments (1)
.github/workflows/fw-lite.yaml (1)
320-327: Verify the Windows SDK and MakeAppx on a windows-latest runner (run PowerShell on Windows)The prior run produced no output because PowerShell was executed in a Bash/Linux shell — rerun this on a windows-latest (Windows) runner or locally on Windows and paste the output.
#!/usr/bin/env pwsh Get-ChildItem 'C:\Program Files (x86)\Windows Kits\10\bin' -Directory | Select-Object -ExpandProperty Name $arch = if ([Environment]::Is64BitOperatingSystem) { 'x64' } else { 'x86' } Get-Command MakeAppx.exe -All | Format-Table CommandType, Name, Source -AutoSize Get-ChildItem "C:\Program Files (x86)\Windows Kits\10\bin\*\$arch\MakeAppx.exe" -ErrorAction SilentlyContinue | Select-Object FullName
No description provided.