Adapt performance test to new gha runner

[myieye]

This failed twice today in GHA (1 and 1.1), so I'm upping it a tad.

[coderabbitai]

📝 Walkthrough

Walkthrough

Adjusted a test assertion threshold in QueryEntryTests to allow a higher per-entry time (from 1 to 1.3 microseconds). Added inline comments noting CI variability as rationale. No other code logic or public API changes.

Changes

Cohort / File(s)	Summary of Changes
Test threshold update backend/FwLite/LcmCrdt.Tests/MiniLcmTests/QueryEntryTests.cs	Increased time-per-entry assertion from 1 to 1.3 microseconds; added inline comments about CI variability; no functional logic changes.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Poem

A bunny taps the timer’s glass,
Hops count microseconds as they pass.
From 1 to 1.3 we go,
CI winds can bluster so—
Still, the tests all neatly run,
Carrots logged, and work well done. 🥕⏱️

Pre-merge checks and finishing touches

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	You can run @coderabbitai generate docstrings to improve docstring coverage.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Title Check	✅ Passed	The title succinctly and accurately summarizes the main change—adjusting a performance test to accommodate the new GHA runner—which matches the changes that relax the per-entry timing assertion in the tests.
Description Check	✅ Passed	The description clearly states the reason for the change (the test failed on GHA and the threshold is being raised) and directly relates to the modifications in the changeset that increase the allowed per-entry time.

✨ Finishing touches

• 📝 Generate Docstrings

🧪 Generate unit tests

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch adapt-performance-test-to-new-gha-runner

Tip

👮 Agentic pre-merge checks are now available in preview!

Pro plan users can now enable pre-merge checks in their settings to enforce checklists before merging PRs.

• Built-in checks – Quickly apply ready-made checks to enforce title conventions, require pull request descriptions that follow templates, validate linked issues for compliance, and more.
• Custom agentic checks – Define your own rules using CodeRabbit’s advanced agentic capabilities to enforce organization-specific policies and workflows. For example, you can instruct CodeRabbit’s agent to verify that API documentation is updated whenever API schema files are modified in a PR. Note: Upto 5 custom checks are currently allowed during the preview period. Pricing for this feature will be announced in a few weeks.

Please see the documentation for more information.

Example:

reviews:
  pre_merge_checks:
    custom_checks:
      - name: "Undocumented Breaking Changes"
        mode: "warning"
        instructions: |
          Pass/fail criteria: All breaking changes to public APIs, CLI flags, environment variables, configuration keys, database schemas, or HTTP/GraphQL endpoints must be documented in the "Breaking Change" section of the PR description and in CHANGELOG.md. Exclude purely internal or private changes (e.g., code not exported from package entry points or explicitly marked as internal).

Please share your feedback with us on this Discord post.

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[argos-ci]

The latest updates on your projects. Learn more about Argos notifications ↗︎

Build	Status	Details	Updated (UTC)
default (Inspect)	✅ No changes detected	-	Sep 15, 2025, 2:00 PM

[github-actions]

UI unit Tests

  1 files  ±0   45 suites  ±0   29s ⏱️ -1s
111 tests ±0  111 ✅ ±0  0 💤 ±0  0 ❌ ±0 
160 runs  ±0  160 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit ec9fea7. ± Comparison against base commit 13cf941.

[coderabbitai]

Actionable comments posted: 0

🧹 Nitpick comments (4)

backend/FwLite/LcmCrdt.Tests/MiniLcmTests/QueryEntryTests.cs (4)

70-72: Make the perf assertion inclusive to cut flakes on CI.

Use <= to account for rounding jitter; include a brief reason.

-        timePerEntry.TotalMicroseconds.Should().BeLessThan(1.3);
+        timePerEntry.TotalMicroseconds.Should().BeLessOrEqualTo(1.3, 
+            "CI variability on the new Windows runner");

---

39-43: Comment says “disabled” but 100_000 case still runs. Align intent.

Either remove it from InlineData or clearly mark it as local-only.

-    //disabled because it takes too long to run
-    [InlineData(100_000)]
+    // disabled on CI because it takes too long to run; enable locally as needed
+    // [InlineData(100_000)]

---

56-58: Add a quick warm‑up before measuring to reduce JIT/plan noise.

Warm‑up once outside the timed region.

-        var testIterations = 10;
-        var startTimestamp = Stopwatch.GetTimestamp();
+        var testIterations = 10;
+        // Warm-up outside measurement to stabilize JIT/EF/LINQ-to-DB paths
+        _ = await Api.SearchEntries("tes").Take(1).ToArrayAsync();
+        var startTimestamp = Stopwatch.GetTimestamp();

---

60-61: Fix misleading comment: this query does match a subset.

Adjust wording to reflect reality and avoid confusion.

-            //search should not match anything as we only want to test the match performance
+            // We’re measuring match performance; the query will match a subset (sanity-checked below)

📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 13cf941 and ec9fea7.

📒 Files selected for processing (1)

• backend/FwLite/LcmCrdt.Tests/MiniLcmTests/QueryEntryTests.cs (1 hunks)

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (4)

• GitHub Check: frontend-component-unit-tests
• GitHub Check: frontend
• GitHub Check: Build FW Lite and run tests
• GitHub Check: Analyze (csharp)