-
-
Notifications
You must be signed in to change notification settings - Fork 5
Fix 16 kb page-size warning and other android warnings #2017
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Important Review skippedAuto incremental reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the 📝 WalkthroughWalkthroughIntroduces Mono.Unix as a centrally managed package and references it in FwLiteMaui with assets excluded. Cleans up unused using directives in several files. Adjusts Android WebChromeClient initialization in MainPage.xaml.Android.cs to use a version-aware base client and removes SetGeolocationDatabasePath. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10–15 minutes Suggested labels
Suggested reviewers
Poem
Pre-merge checks and finishing touches❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
The latest updates on your projects. Learn more about Argos notifications ↗︎
|
C# Unit Tests130 tests 130 ✅ 20s ⏱️ Results for commit e8ea855. ♻️ This comment has been updated with latest results. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (6)
backend/Directory.Packages.props(2 hunks)backend/FwLite/FwDataMiniLcmBridge/Api/RichTextMapping.cs(0 hunks)backend/FwLite/FwLiteMaui/FwLiteMaui.csproj(1 hunks)backend/FwLite/FwLiteMaui/MainPage.xaml.Android.cs(1 hunks)backend/Testing/Services/JwtHelper.cs(0 hunks)backend/Testing/Services/ModifyProjectHelper.cs(0 hunks)
💤 Files with no reviewable changes (3)
- backend/Testing/Services/JwtHelper.cs
- backend/FwLite/FwDataMiniLcmBridge/Api/RichTextMapping.cs
- backend/Testing/Services/ModifyProjectHelper.cs
🧰 Additional context used
🧠 Learnings (1)
📚 Learning: 2025-08-07T08:35:47.803Z
Learnt from: hahn-kev
PR: sillsdev/languageforge-lexbox#1885
File: backend/FwLite/FwLiteMaui/MainPage.xaml.Windows.cs:30-41
Timestamp: 2025-08-07T08:35:47.803Z
Learning: In backend/FwLite/FwLiteMaui/MainPage.xaml.Windows.cs, the SetPermissionStateAsync calls in BlazorWebViewInitialized method are intentionally used in a fire-and-forget pattern with pragma warning suppression for VSTHRD110, as awaiting them is not necessary and async void should be avoided.
Applied to files:
backend/FwLite/FwLiteMaui/MainPage.xaml.Android.cs
🧬 Code graph analysis (1)
backend/FwLite/FwLiteMaui/MainPage.xaml.Android.cs (1)
backend/FwLite/FwLiteMaui/Platforms/Android/PermissionManagingBlazorWebChromeClient.cs (2)
PermissionManagingBlazorWebChromeClient(21-231)PermissionManagingBlazorWebChromeClient(57-62)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (6)
- GitHub Check: Build API / publish-api
- GitHub Check: Build FwHeadless / publish-fw-headless
- GitHub Check: Analyze (csharp)
- GitHub Check: Build FW Lite and run tests
- GitHub Check: frontend
- GitHub Check: frontend-component-unit-tests
🔇 Additional comments (2)
backend/FwLite/FwLiteMaui/FwLiteMaui.csproj (1)
88-96: Verify runtime after Mono.Unix exclusion
Static search found noMono.Unixreferences in any .cs files. Confirm at runtime that FwLiteMaui features work, SIL.WritingSystems/SIL.LCMModel have no missing APIs, and the 16 KB page-size warnings are resolved.backend/FwLite/FwLiteMaui/MainPage.xaml.Android.cs (1)
35-38: Clarify Android version rationale and geolocation API deprecation
WebSettings.setGeolocationDatabasePathwas deprecated in API 24; modern WebView manages storage internally—useWebSettings.setGeolocationEnabledplusWebChromeClient.onGeolocationPermissionsShowPromptwith runtime location permissions.- Explain why on Android 26+ you reuse
e.WebView.WebChromeClientif set versus always creating a new instance on older OS versions.
aad14f9 to
e8ea855
Compare
See: https://devblogs.microsoft.com/dotnet/maui-google-play-16-kb-page-size-support/