Skip to content

Conversation

@myieye
Copy link
Collaborator

@myieye myieye commented Oct 6, 2025

JSON Serializer options should generally be reused and not instantiated on demand.
There were also some open TODOs regarding reusing options.

@github-actions github-actions bot added the 💻 FW Lite issues related to the fw lite application, not miniLcm or crdt related label Oct 6, 2025
@coderabbitai
Copy link

coderabbitai bot commented Oct 6, 2025

Warning

Rate limit exceeded

@myieye has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 4 minutes and 12 seconds before requesting another review.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

📥 Commits

Reviewing files that changed from the base of the PR and between ef484ee and f208f91.

📒 Files selected for processing (7)
  • backend/FwLite/FwLiteProjectSync.Tests/ProjectSnapshotSerializationTests.cs (2 hunks)
  • backend/FwLite/FwLiteProjectSync.Tests/Sena3SyncTests.cs (2 hunks)
  • backend/FwLite/LcmCrdt.Tests/Changes/ChangeSerializationTests.cs (8 hunks)
  • backend/FwLite/LcmCrdt.Tests/Data/BaseSerializationTest.cs (3 hunks)
  • backend/FwLite/LcmCrdt.Tests/Data/MigrationTests.cs (3 hunks)
  • backend/FwLite/LcmCrdt.Tests/Data/SnapshotDeserializationTests.cs (7 hunks)
  • backend/FwLite/MiniLcm.Tests/RichText/ColorJsonConverterTests.cs (2 hunks)
✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch tidy-up-test-json-options

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@argos-ci
Copy link

argos-ci bot commented Oct 6, 2025

The latest updates on your projects. Learn more about Argos notifications ↗︎

Build Status Details Updated (UTC)
default (Inspect) ✅ No changes detected - Oct 6, 2025, 9:03 AM

@github-actions
Copy link

github-actions bot commented Oct 6, 2025

UI unit Tests

  1 files  ±0   45 suites  ±0   29s ⏱️ -1s
111 tests ±0  111 ✅ ±0  0 💤 ±0  0 ❌ ±0 
160 runs  ±0  160 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit f208f91. ± Comparison against base commit ef484ee.

@myieye myieye merged commit b369f12 into develop Oct 8, 2025
16 checks passed
@myieye myieye deleted the tidy-up-test-json-options branch October 8, 2025 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

💻 FW Lite issues related to the fw lite application, not miniLcm or crdt related

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants