Skip to content

Conversation

@pmachapman
Copy link
Collaborator

@pmachapman pmachapman commented Sep 11, 2025

Fixes #743


This change is Reviewable

Copy link
Collaborator

@Enkidu93 Enkidu93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

@Enkidu93 reviewed 4 of 4 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @ddaspit)

Copy link
Contributor

@ddaspit ddaspit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

@ddaspit reviewed 4 of 4 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @pmachapman)

@pmachapman pmachapman force-pushed the cancel_build_if_no_data branch from 2bd58aa to 971931c Compare September 15, 2025 19:03
@codecov-commenter
Copy link

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 66.40%. Comparing base (8d1e489) to head (971931c).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #754      +/-   ##
==========================================
+ Coverage   66.38%   66.40%   +0.01%     
==========================================
  Files         369      369              
  Lines       19680    19685       +5     
  Branches     2511     2512       +1     
==========================================
+ Hits        13065    13072       +7     
+ Misses       5700     5699       -1     
+ Partials      915      914       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@pmachapman pmachapman merged commit 5298d4a into main Sep 15, 2025
3 checks passed
@pmachapman pmachapman deleted the cancel_build_if_no_data branch September 15, 2025 19:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

If there is no data to be pretranslated and the model is not being persisted, stop the build early

5 participants