Clean up errors and warnings #864
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TaperChipmunk32
approved these changes
Nov 13, 2025
Collaborator
TaperChipmunk32
left a comment
TaperChipmunk32
left a comment
There was a problem hiding this comment.
Reviewable status: 0 of 12 files reviewed, all discussions resolved
TaperChipmunk32
approved these changes
Nov 14, 2025
Collaborator
TaperChipmunk32
left a comment
TaperChipmunk32
left a comment
There was a problem hiding this comment.
@TaperChipmunk32 reviewed 12 of 12 files at r1, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @benjaminking)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The various linters and type-checkers end up generating a lot of errors and warnings for SILNLP, which can make it difficult to spot real errors. This PR tries to correct some of low-hanging fruit in this area. I didn't go over the whole project, just the files we end up editing most often, and I also didn't correct all the errors or warnings. Some of them, like the type issues with our config objects, will require a more fundamental rework to fix.
I don't know that I necessarily corrected all of these in the "proper" or best way, so feel free to push back on anything that seems like it could be done better differently.
This change is