Skip to content

Conversation

@pmachapman
Copy link
Collaborator

@pmachapman pmachapman commented Aug 12, 2025

This PR adds a missing resource string for the final phase of a string when a percentage is reported.


This change is Reviewable

@codecov
Copy link

codecov bot commented Aug 12, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 82.42%. Comparing base (05b66ef) to head (5992567).
⚠️ Report is 106 commits behind head on master.
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #3363   +/-   ##
=======================================
  Coverage   82.42%   82.42%           
=======================================
  Files         607      607           
  Lines       35571    35571           
  Branches     5778     5802   +24     
=======================================
  Hits        29319    29319           
+ Misses       5389     5373   -16     
- Partials      863      879   +16     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@Nateowami Nateowami left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @pmachapman)

@Nateowami Nateowami merged commit cd97180 into master Aug 12, 2025
18 checks passed
@Nateowami Nateowami deleted the fix/phase_8_percent branch August 12, 2025 21:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants