-
-
Notifications
You must be signed in to change notification settings - Fork 5
Remove dead code #3529
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove dead code #3529
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR removes unused public members and imports that were identified as dead code across multiple components in the Scripture Forge application. The changes streamline the codebase by eliminating properties, methods, and imports that are no longer referenced.
- Removes unused getter properties, methods, and class fields
- Eliminates unused imports (environment)
- Cleans up both component logic and UI-related helper methods
Reviewed Changes
Copilot reviewed 13 out of 13 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| collaborators.component.ts | Removed unused getters hasEmailError and totalUsers |
| suggestions.component.ts | Removed unused showHelp property and toggleHelp() method |
| lynx-insights-panel.component.ts | Removed unused getRemainingNodeCount() method |
| draft-sources.component.ts | Removed unused targetLanguageTag getter |
| draft-generation.component.ts | Removed unused issueEmail getter and unused environment import |
| biblical-terms.component.ts | Removed unused selectedReferenceForCaption getter |
| serval-project.component.ts | Removed unused draftSourcesLink getter |
| permissions-viewer.component.ts | Removed unused hasOperation() method |
| my-projects.component.ts | Removed unused currentUserRole() method |
| connect-project.component.ts | Removed unused isBasedOnProjectSet getter and logInWithParatext() method |
| checking-questions.component.ts | Removed unused activeQuestionChapter getter, nextQuestion(), previousQuestion(), and changeQuestion() methods |
| checking-answers.component.ts | Removed unused canShowScriptureInput and hasUserRead getters |
| chapter-audio-dialog.component.ts | Removed unused _editState field, inEditState getter, and assignment to _editState |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #3529 +/- ##
==========================================
+ Coverage 82.42% 82.48% +0.06%
==========================================
Files 615 615
Lines 36948 36914 -34
Branches 6045 6033 -12
==========================================
- Hits 30453 30450 -3
+ Misses 5597 5579 -18
+ Partials 898 885 -13 ☔ View full report in Codecov by Sentry. |
|
(e2e tests passed on this PR. I've removed the label, as I don't think they need to be re-run if this PR is updated and/or rebased) |
RaymondLuong3
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@RaymondLuong3 reviewed 13 of 13 files at r1, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @Nateowami)
It's bugged me that sometimes we have public members that are actually dead code. I asked Copilot to find instances of this, but instead it wrote a script to find them, which worked pretty well, but had a lot of false positives (usually for somewhat understandable reasons; not glaring problems with the script). This PR removes the code that's truly dead.
This change is