Skip to content

Conversation

@jkseppan
Copy link
Contributor

@jkseppan jkseppan commented Dec 3, 2022

I suggested this in #16 (comment)

@zefhemel
Copy link
Collaborator

zefhemel commented Dec 3, 2022

Looks good! My only question is if hostname the right term. Maybe bind IP or simply an --ip flag instead?

@zephraph
Copy link

zephraph commented Dec 4, 2022

Hostname matches what oak expects to be passed.

this.app.listen({ hostname: this.hostname, port: this.port, signal: this.abortController.signal })

I'd also say --hostname should be understood to be includes of explicit IPs whereas --ip would likely not. Probably isn't really a big deal either way so long as it's documented.

@zefhemel
Copy link
Collaborator

zefhemel commented Dec 4, 2022

Good point. Alright. Merging this, thanks a lot!

@zefhemel zefhemel merged commit 9baac21 into silverbulletmd:main Dec 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants