Skip to content

Conversation

@pt-tsl
Copy link
Contributor

@pt-tsl pt-tsl commented Feb 5, 2025

Acceptance Criteria

  • Given I hover my mouse over a message, when the overlay 3 dots menu appears and I click on it, then I should see a "Delete" option in the menu. (Should already be implemented)
  • Given I click the "Delete" option then, a dialog/delete message should confirm if I am sure that I want to delete the message.
    • The confirmation message changes if it's an individual chat or a group chat
  • Given I click the "Delete" option to confirm, the text should be replaced with "You deleted this message" in gray font.
    • For others in the chat (individual or in a group) the text should be replaced with "This message was deleted." in gray front.
  • A toast message should appear notifying that the message was deleted.
    • Use the existing info icon, not the delete icon for now, nor the Undo button.
    • Make the component as similar as the design as possible.
    • Use the new timed snack-bar component

Guardrail
The snackbar will not have the action button for now

Design Link: https://www.figma.com/design/XRD6wSl1m8Kz6XUcAy5CLp/BaseApp---WEB?node-id=7763-127162&t=MOMbprMUFediIBZh-0

Note: The snackbar has been implemented in another PR
silverlogic/baseapp-frontend#207

@coderabbitai
Copy link

coderabbitai bot commented Feb 5, 2025

Important

Review skipped

Auto reviews are disabled on this repository.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@pt-tsl pt-tsl force-pushed the BA-2213-delete-chat-message branch from 6554870 to 4ba2409 Compare February 5, 2025 16:51


class ChatRoomDeleteMessage(RelayMutation):
deleted_message = graphene.Field(MessageObjectType._meta.connection.Edge)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is no need to return the deleted_message, you are required to return only its relay ID to make relay in the frontend remove the message from the store. This follows better the relay/graphql pattern.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But we're doing a soft delete, so this is more like a message update than an actual deletion. We're just updating the deleted flag so we can replace the content of the message with the default deletion copy.

@pt-tsl pt-tsl requested a review from nossila February 7, 2025 12:38
@pt-tsl pt-tsl force-pushed the BA-2213-delete-chat-message branch from 4ba2409 to d68d5d3 Compare February 7, 2025 14:46
@pt-tsl pt-tsl requested a review from tsl-ps2 February 7, 2025 14:47
)

if not info.context.user.has_perm(
"baseapp_chats.change_message",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be "baseapp_chats.delete_message", right?

Copy link
Contributor

@tsl-ps2 tsl-ps2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left one last minor comment which should take only a few seconds to fix.

@pt-tsl pt-tsl force-pushed the BA-2213-delete-chat-message branch from d68d5d3 to 273cf7c Compare February 10, 2025 20:37
@pt-tsl pt-tsl force-pushed the BA-2213-delete-chat-message branch 3 times, most recently from 88287af to 537235b Compare February 14, 2025 13:10
@pt-tsl pt-tsl force-pushed the BA-2213-delete-chat-message branch from 537235b to 3d562ca Compare February 18, 2025 12:19
@sonarqubecloud
Copy link

Quality Gate Failed Quality Gate failed for 'silverlogic_baseapp-backend_baseapp-chats'

Failed conditions
0.0% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube Cloud

@pt-tsl pt-tsl merged commit cfde3f4 into master Feb 18, 2025
28 of 31 checks passed
@nossila nossila deleted the BA-2213-delete-chat-message branch April 3, 2025 19:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants