Skip to content

Conversation

@simPod
Copy link
Owner

@simPod simPod commented Aug 8, 2025

Summary by CodeRabbit

  • Refactor
    • Updated multiple classes throughout the project to be immutable after construction, enhancing reliability and predictability.
    • Improved type declarations for certain constants to provide stricter type safety.

@coderabbitai
Copy link

coderabbitai bot commented Aug 8, 2025

Caution

Review failed

The pull request is closed.

Walkthrough

The changes convert numerous class declarations across the codebase to use the readonly modifier, enforcing immutability of all class properties after construction. In a few cases, constant declarations are also explicitly typed. No changes were made to methods, logic, or control flow in any of the affected classes.

Changes

Cohort / File(s) Change Summary
Client Classes
src/Client/Http/RequestFactory.php, src/Client/Http/RequestOptions.php, src/Client/Http/RequestSettings.php, src/Client/PsrClickHouseAsyncClient.php, src/Client/PsrClickHouseClient.php
All classes updated to use the readonly modifier, making their properties immutable after construction. No other changes.
Format Classes
src/Format/Json.php, src/Format/JsonCompact.php, src/Format/JsonEachRow.php, src/Format/Null_.php, src/Format/Pretty.php, src/Format/PrettySpace.php, src/Format/RowBinary.php, src/Format/TabSeparated.php
All classes updated to final readonly class, enforcing immutability. No changes to methods or logic.
Logger Classes
src/Logger/LoggerChain.php, src/Logger/PsrLogger.php
Both logger classes updated to final readonly class, making properties immutable after construction. No other changes.
Output Classes
src/Output/Basic.php, src/Output/Json.php, src/Output/JsonCompact.php, src/Output/JsonEachRow.php, src/Output/Null_.php
All output classes updated to final readonly class, enforcing immutability. No other logic changes.
Param Registry
src/Param/ParamValueConverterRegistry.php
Class updated to final readonly class. Constant CaseInsensitiveTypes now explicitly typed as array. No logic changes.
Snippet Classes
src/Snippet/CurrentDatabase.php, src/Snippet/DatabaseSize.php, src/Snippet/Parts.php, src/Snippet/ShowCreateTable.php, src/Snippet/ShowDatabases.php, src/Snippet/TableSizes.php, src/Snippet/Version.php
All snippet classes updated to final readonly class, making properties immutable. No other changes.
SQL Utility Classes
src/Sql/Escaper.php, src/Sql/Expression.php, src/Sql/SqlFactory.php
All SQL utility classes updated to final readonly class, enforcing immutability. No changes to logic or methods.
Test Utility
tests/ClickHouseVersion.php
Class updated to final readonly class. Constant EnvName now explicitly typed as string. No logic changes.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Note

🔌 MCP (Model Context Protocol) integration is now available in Early Access!

Pro users can now connect to remote MCP servers under the Integrations page to get reviews and chat conversations that understand additional development context.


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 5caa6ff and b81d5d9.

📒 Files selected for processing (32)
  • src/Client/Http/RequestFactory.php (1 hunks)
  • src/Client/Http/RequestOptions.php (1 hunks)
  • src/Client/Http/RequestSettings.php (1 hunks)
  • src/Client/PsrClickHouseAsyncClient.php (1 hunks)
  • src/Client/PsrClickHouseClient.php (1 hunks)
  • src/Format/Json.php (1 hunks)
  • src/Format/JsonCompact.php (1 hunks)
  • src/Format/JsonEachRow.php (1 hunks)
  • src/Format/Null_.php (1 hunks)
  • src/Format/Pretty.php (1 hunks)
  • src/Format/PrettySpace.php (1 hunks)
  • src/Format/RowBinary.php (1 hunks)
  • src/Format/TabSeparated.php (1 hunks)
  • src/Logger/LoggerChain.php (1 hunks)
  • src/Logger/PsrLogger.php (1 hunks)
  • src/Output/Basic.php (1 hunks)
  • src/Output/Json.php (1 hunks)
  • src/Output/JsonCompact.php (1 hunks)
  • src/Output/JsonEachRow.php (1 hunks)
  • src/Output/Null_.php (1 hunks)
  • src/Param/ParamValueConverterRegistry.php (1 hunks)
  • src/Snippet/CurrentDatabase.php (1 hunks)
  • src/Snippet/DatabaseSize.php (1 hunks)
  • src/Snippet/Parts.php (1 hunks)
  • src/Snippet/ShowCreateTable.php (1 hunks)
  • src/Snippet/ShowDatabases.php (1 hunks)
  • src/Snippet/TableSizes.php (1 hunks)
  • src/Snippet/Version.php (1 hunks)
  • src/Sql/Escaper.php (1 hunks)
  • src/Sql/Expression.php (1 hunks)
  • src/Sql/SqlFactory.php (1 hunks)
  • tests/ClickHouseVersion.php (1 hunks)
✨ Finishing Touches
  • 📝 Generate Docstrings
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch readonly

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai generate unit tests to generate unit tests for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@codecov
Copy link

codecov bot commented Aug 8, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 94.66%. Comparing base (5caa6ff) to head (b81d5d9).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #303   +/-   ##
=======================================
  Coverage   94.66%   94.66%           
=======================================
  Files          40       40           
  Lines         750      750           
=======================================
  Hits          710      710           
  Misses         40       40           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@simPod simPod merged commit 8eb584f into master Aug 8, 2025
14 of 15 checks passed
@simPod simPod deleted the readonly branch August 8, 2025 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants