Skip to content

refactor: drop readonly in client classes #305

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 9, 2025
Merged

refactor: drop readonly in client classes #305

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/Client/PsrClickHouseAsyncClient.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@

use function uniqid;

readonly class PsrClickHouseAsyncClient implements ClickHouseAsyncClient
class PsrClickHouseAsyncClient implements ClickHouseAsyncClient
{
private SqlFactory $sqlFactory;

Expand Down Expand Up @@ -98,14 +98,14 @@
);

$id = uniqid('', true);
$this->sqlLogger?->startQuery($id, $sql);

Check warning on line 101 in src/Client/PsrClickHouseAsyncClient.php

View workflow job for this annotation

GitHub Actions / Infection 

Escaped Mutant for Mutator "MethodCallRemoval":

@@ @@
     {
         $request = $this->requestFactory->prepareSqlRequest($sql, new RequestSettings($this->defaultSettings, $settings), new RequestOptions($params));
         $id = uniqid('', true);
-        $this->sqlLogger?->startQuery($id, $sql);
+        
         return Create::promiseFor($this->asyncClient->sendAsyncRequest($request))->then(function (ResponseInterface $response) use ($id, $processResponse) {
             $this->sqlLogger?->stopQuery($id);
             if ($response->getStatusCode() !== 200) {

return Create::promiseFor(
$this->asyncClient->sendAsyncRequest($request),
)
->then(
function (ResponseInterface $response) use ($id, $processResponse) {
$this->sqlLogger?->stopQuery($id);

Check warning on line 108 in src/Client/PsrClickHouseAsyncClient.php

View workflow job for this annotation

GitHub Actions / Infection 

Escaped Mutant for Mutator "MethodCallRemoval":

@@ @@
         $id = uniqid('', true);
         $this->sqlLogger?->startQuery($id, $sql);
         return Create::promiseFor($this->asyncClient->sendAsyncRequest($request))->then(function (ResponseInterface $response) use ($id, $processResponse) {
-            $this->sqlLogger?->stopQuery($id);
+            
             if ($response->getStatusCode() !== 200) {
                 throw ServerError::fromResponse($response);
             }

if ($response->getStatusCode() !== 200) {
throw ServerError::fromResponse($response);
Expand All @@ -117,7 +117,7 @@

return $processResponse($response);
},
fn () => $this->sqlLogger?->stopQuery($id),

Check warning on line 120 in src/Client/PsrClickHouseAsyncClient.php

View workflow job for this annotation

GitHub Actions / Infection 

Escaped Mutant for Mutator "NullSafeMethodCall":

@@ @@
                 return $response;
             }
             return $processResponse($response);
-        }, fn() => $this->sqlLogger?->stopQuery($id));
+        }, fn() => $this->sqlLogger->stopQuery($id));
     }
 }
);
}
}
2 changes: 1 addition & 1 deletion src/Client/PsrClickHouseClient.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@
use function sprintf;
use function uniqid;

readonly class PsrClickHouseClient implements ClickHouseClient
class PsrClickHouseClient implements ClickHouseClient
{
private ValueFormatter $valueFormatter;

Expand Down
Loading