Skip to content

Conversation

@simPod
Copy link
Owner

@simPod simPod commented Oct 29, 2025

No description provided.

@simPod
Copy link
Owner Author

simPod commented Oct 29, 2025

@copilot

@simPod simPod requested a review from Copilot October 29, 2025 08:38
Copilot AI mentioned this pull request Oct 29, 2025
Copy link

Copilot AI commented Oct 29, 2025

@simPod I've opened a new pull request, #246, to work on those changes. Once the pull request is ready, I'll request review from you.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR standardizes PHPDoc callable type annotations by removing spaces around colons and properly adding nullable union syntax.

  • Removed spaces around colons in callable type signatures (e.g., callable() : voidcallable():void)
  • Added nullable union syntax to optional callable parameters using |null instead of implicit nullability
  • Applied consistent formatting across all method docblocks in the KafkaConsumer class

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@codecov
Copy link

codecov bot commented Oct 29, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 71.36%. Comparing base (979cd87) to head (6454487).
⚠️ Report is 16 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #245      +/-   ##
==========================================
+ Coverage   70.40%   71.36%   +0.95%     
==========================================
  Files           9        9              
  Lines         223      213      -10     
==========================================
- Hits          157      152       -5     
+ Misses         66       61       -5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@simPod simPod merged commit 9c2f544 into master Oct 29, 2025
6 checks passed
@simPod simPod deleted the types branch October 29, 2025 08:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants