Skip to content

Conversation

@simenandre
Copy link
Owner

This is quite a large pull request that adds 100% test coverage for two new methods; fastify-plugin and cloud functions. To improve readabilty, the server function changed from createPubSubHandler to createPubSubServer.

BREAKING CHANGES: createPubSubHandler changed to createPubSubServer

This is quite a large pull request that adds 100% test coverage for two new _methods_; fastify-plugin and cloud functions. To improve readabilty, the server function changed from `createPubSubHandler` to `createPubSubServer`.

BREAKING CHANGES: `createPubSubHandler` changed to `createPubSubServer`
* main:
  chore: normalize package.json
@codecov-commenter
Copy link

Codecov Report

Merging #9 (543b902) into main (f9fb7cf) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##              main        #9   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            1         6    +5     
  Lines           22        49   +27     
  Branches         6        10    +4     
=========================================
+ Hits            22        49   +27     
Impacted Files Coverage Δ
src/common.ts 100.00% <100.00%> (ø)
src/index.ts 100.00% <100.00%> (ø)
src/methods/cloud-functions.ts 100.00% <100.00%> (ø)
src/methods/fastify-plugin.ts 100.00% <100.00%> (ø)
src/methods/server.ts 100.00% <100.00%> (ø)
src/types.ts 100.00% <100.00%> (ø)
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f9fb7cf...543b902. Read the comment docs.

@simenandre simenandre merged commit 18b1d32 into main Aug 29, 2021
@simenandre simenandre deleted the v2 branch August 29, 2021 19:02
@github-actions github-actions bot mentioned this pull request Aug 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants