feat: restructure to allow usage in other mode projects#269
Merged
simllll merged 2 commits intosimllll:masterfrom Apr 6, 2022
Merged
feat: restructure to allow usage in other mode projects#269simllll merged 2 commits intosimllll:masterfrom
simllll merged 2 commits intosimllll:masterfrom
Conversation
- move code from app.ts into RadiusServer.ts - replace logging with a logger specified via the RadiusServer options - export RadiusServer and associated types
and make some server options optional
Contributor
Author
|
Side note: this package.json indicates GPLv3 as license but the repo doesn’t actually include any licenses. |
simllll
approved these changes
Apr 6, 2022
| dns[index] = entry.object.dn; | ||
| }); | ||
| }); | ||
|
|
Owner
There was a problem hiding this comment.
Looks clean to me :) thanks, i will do one finale check before approving regarding the cli command, but if this works, then its good to go :) thanks for refactoring
Owner
|
Thanks for your contribution! |
Owner
|
releassed as major 2.x release, but I also converted it to an ESM package. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This allows this module to be used in other node projects: