feat: added api error if incorrect request method is used

Author: Lukas Siemon

lib/api.js

@@ -10,6 +10,13 @@ const endpoints = {};
 const Parser = (request, params) => {
   endpoints[request] = params;
   return (event) => {
+    const expectedRequestMethod = request.split(" ")[0];
+    const receivedRequestMethod = get(event, 'httpMethod');
+    if (receivedRequestMethod !== expectedRequestMethod) {
+      throw response.ApiError(`Request Method "${expectedRequestMethod}" expected.`, 400, 99004, {
+        value: receivedRequestMethod
+      });
+    }
     let body;
     try {
       body = JSON.parse(get(event, 'body', '{}'));

test/handler/__cassettes/test_param_invalid_method.json_recording.json

@@ -0,0 +1 @@
+[]

test/handler/test_error.json

@@ -12,5 +12,7 @@
       "to.deep.equal": []
     }
   ],
-  "event": {}
+  "event": {
+    "httpMethod": "GET"
+  }
 }

test/handler/test_exception.json

@@ -12,5 +12,7 @@
       "to.deep.equal": []
     }
   ],
-  "event": {}
+  "event": {
+    "httpMethod": "GET"
+  }
 }

test/handler/test_json.json

@@ -12,5 +12,7 @@
       "to.deep.equal": []
     }
   ],
-  "event": {}
+  "event": {
+    "httpMethod": "GET"
+  }
 }

test/handler/test_param.json

@@ -16,6 +16,7 @@
     "queryStringParameters": {
       "ref": "12345"
     },
-    "body": "{\"username\": \"Anja Smith\", \"email\": \"anja@test.ca\"}"
+    "body": "{\"username\": \"Anja Smith\", \"email\": \"anja@test.ca\"}",
+    "httpMethod": "POST"
   }
 }

test/handler/test_param_invalid_body.json

@@ -13,6 +13,7 @@
     }
   ],
   "event": {
-    "body": "invalid_json_string"
+    "body": "invalid_json_string",
+    "httpMethod": "POST"
   }
 }

test/handler/test_param_invalid_email.json

@@ -13,6 +13,7 @@
     }
   ],
   "event": {
-    "body": "{\"username\": \"Anja Smith\", \"email\": \"invalid@email\"}"
+    "body": "{\"username\": \"Anja Smith\", \"email\": \"invalid@email\"}",
+    "httpMethod": "POST"
   }
 }

test/handler/test_param_invalid_method.json

@@ -0,0 +1,18 @@
+{
+  "handler": "param",
+  "success": true,
+  "timeout": 2000,
+  "response": [
+    {
+      "to.deep.equal": "{\"statusCode\":400,\"body\":\"{\\\"message\\\":\\\"Request Method \\\\\\\"POST\\\\\\\" expected.\\\",\\\"messageId\\\":99004,\\\"context\\\":{\\\"value\\\":\\\"GET\\\"}}\"}"
+    }
+  ],
+  "logs": [
+    {
+      "to.deep.equal": []
+    }
+  ],
+  "event": {
+    "httpMethod": "GET"
+  }
+}

test/handler/test_param_missing_required.json

@@ -13,6 +13,7 @@
     }
   ],
   "event": {
-    "body": "{}"
+    "body": "{}",
+    "httpMethod": "POST"
   }
 }