feat: throwing error if GET method with json parameters is used

Author: Lukas Siemon

lib/api.js

@@ -56,6 +56,9 @@ module.exports = (options = {}) => {
   const limiter = Limiter(get(options, 'limiter', {}));
 
   const wrap = (request, params, limit, handler) => {
+    if (request.startsWith("GET ") && params.filter(p => p.position === 'json').length !== 0) {
+      throw new Error("Can not use JSON parameter with GET requests.");
+    }
     const parser = Parser(request, params);
     return rollbar
       .wrap((event, context, callback, rb) => limiter

package.json

@@ -14,6 +14,7 @@
   "author": "Lukas Siemon",
   "devDependencies": {
     "app-root-path": "2.0.1",
+    "chai": "4.1.2",
     "coveralls": "3.0.0",
     "js-gardener": "1.11.18",
     "semantic-release": "12.4.1",

test/test_param.js

@@ -0,0 +1,10 @@
+const expect = require('chai').expect;
+const api = require("../lib/api")();
+
+describe("Testing Params", () => {
+  it("Testing Error for GET And JSON Param", (done) => {
+    expect(() => api.wrap("GET route", [api.Str("name", "json")], 1, () => {}))
+      .to.throw("Can not use JSON parameter with GET requests.");
+    done();
+  });
+});