Update tests dir validation logic #4
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
|
Eek, I just hit this one too! Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Found this while developing a package using this repo. My PR tests were passing, but the publish failed due to testing failures.
What I saw was that because I had some tests fail, the step was returning the echo "Tests directory not found", and the step was successful.
https://github.com/glasnt/janky/commits/showcase/ shows the issue and resolution I experienced.
Current version causes the right side to execute if either left side fails (including pytest failing). Suggested fix turns the check into a full conditional.
(Submitted in a GitHub-web based editing, as making a full fork to then submit a patch ran the initial Workflow and the PR had a whole lot more files than expected 😅 )