Skip to content

Conversation

@simonw
Copy link
Owner

@simonw simonw commented Jul 17, 2025

Summary

  • correct July dates for Open Sauce 2025 in docs and HTML
  • update day tab labels and ICS generation dates

Testing

  • pytest -q (fails: ModuleNotFoundError: No module named 'playwright')

https://chatgpt.com/codex/tasks/task_e_68793939c7088326a376a88c11af6544

@claude
Copy link
Contributor

claude bot commented Jul 17, 2025

Claude finished @simonw's task —— View job


PR Review: Fix Open Sauce schedule dates

  • Read changed files to understand modifications
  • Analyze changes for potential bugs and issues
  • Review code quality and best practices
  • Check for security concerns
  • Assess performance implications
  • Evaluate test coverage impact
  • Provide comprehensive review feedback

Summary

This PR corrects the Open Sauce 2025 event dates from July 25-27 to July 18-20 across documentation and HTML files. The changes are consistent and well-implemented.

Code Quality ✅

  • Changes are clean and focused
  • All date references are consistently updated
  • Code formatting and structure remain intact

Changes Analysis ✅

The PR updates dates in three locations:

  1. open-sauce-2025.docs.md:1 - Description text: July 25-27, 2025July 18-20, 2025
  2. open-sauce-2025.html:223 - Header display: July 25-27, 2025July 18-20, 2025
  3. open-sauce-2025.html:228-230 - Tab labels: Friday 25th, Saturday 26th, Sunday 27thFriday 18th, Saturday 19th, Sunday 20th
  4. open-sauce-2025.html:358-360 - ICS generation dates: 20250725, 20250726, 2025072720250718, 20250719, 20250720

Date Consistency ✅

All date references are correctly updated:

  • Display dates match ICS generation dates
  • Day-of-week calculations remain correct (Friday→Friday, Saturday→Saturday, Sunday→Sunday)
  • Calendar download functionality will generate correct event dates

Security & Performance ✅

  • No security concerns with date changes
  • No performance impact from static date updates
  • External API calls remain unchanged

Test Coverage ✅

  • Test failure (ModuleNotFoundError: No module named 'playwright') is unrelated to these changes
  • The existing test suite focuses on OCR functionality, not schedule dates
  • Date changes don't require additional test coverage as they're static content updates

Recommendation

✅ APPROVE - This is a straightforward, well-executed date correction with no issues identified. All date references are consistently updated across both display and functional components.


@cloudflare-workers-and-pages
Copy link

Deploying tools with  Cloudflare Pages  Cloudflare Pages

Latest commit: e97476f
Status: ✅  Deploy successful!
Preview URL: https://8777e8cb.tools-b1q.pages.dev
Branch Preview URL: https://codex-fix-open-sauce-schedul.tools-b1q.pages.dev

View logs

@simonw simonw merged commit 7127a8c into main Jul 17, 2025
4 checks passed
simonw pushed a commit that referenced this pull request Nov 5, 2025
- Added decoding of decimal numeric entities (e.g., ")
- Added decoding of hexadecimal numeric entities (e.g., ")
- Updated documentation to reflect numeric entity support
- Now handles all numeric character references, not just named entities
simonw added a commit that referenced this pull request Nov 5, 2025
* Add radio button to toggle between escape and unescape modes

- Added radio buttons to switch between Escape and Unescape modes
- Implemented unescapeHTML function to convert HTML entities back to characters
- Updated output label to dynamically reflect the current mode
- Enhanced documentation to explain both modes of operation
- Added CSS styling for the mode selector controls

* Add support for numeric HTML entities in unescape mode

- Added decoding of decimal numeric entities (e.g., ")
- Added decoding of hexadecimal numeric entities (e.g., ")
- Updated documentation to reflect numeric entity support
- Now handles all numeric character references, not just named entities

* Improve Unescape mode documentation for clarity

- Reorganized documentation into clearer format
- Grouped entity types with better visual separation
- Used arrow notation (→) for better readability
- Consolidated examples to reduce clutter
- Added clearer description of use cases

---------

Co-authored-by: Claude <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants