-
-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update notepadplusplus #5187
Update notepadplusplus #5187
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seeing some differences between your PR (black) and the source icon (red) here - any chance you could look to rebuild it?
Good catch! I started from scratch this time! :) |
This does not look like a fun icon to work on so sorry about this! I'm seeing a small difference in the right eyeball (your version in red) and an even smaller one at the top of the intersection between the tail & the pencil. Also, could you update the source to https://github.com/notepad-plus-plus/notepad-plus-plus/blob/1f2c63cce173e3e1dc5922637c81a851693e2856/PowerEditor/misc/chameleon/chameleon-pencil.eps? |
haha, surely not a fun one 😃, but thanks for the review. I will check this out!
Sure! |
Just gave it another try. Let me know if there is something else! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍🏼 Thanks @service-paradis |
# New Icons - Amazon S3 (#4999) - Commerzbank (#5028) - DatoCMS (#5184) - Enpass (#5174) - Hyper (#5197) - Mercurial (#5157) - Pointy (#4952) - Private Internet Access (#5158) - Stimulus (#5209) - SymPy (#4554) - XState (#4971) # Updated Icons - AlliedModders (#5107) - Code Climate (#5194) - Elsevier (#5175) - Firefox (#5203) - Git (#5213) - Google Ads (#4471) - Monzo (#5219) - Notepad++ (#5187) - pre-commit (#5226) - SparkFun (#5196) - Stack Overflow (#5217)
Issue: #4590
Alexa rank: N/A
Checklist
_data/simple-icons.json
viewbox
is0 0 24 24
Description
I also remove an unnecessary coordinate at the end of the path