Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update notepadplusplus #5187

Merged

Conversation

service-paradis
Copy link
Member

@service-paradis service-paradis commented Mar 5, 2021

image

Issue: #4590
Alexa rank: N/A

Checklist

  • I updated the JSON data in _data/simple-icons.json
  • I optimized the icon with SVGO or SVGOMG
  • The SVG viewbox is 0 0 24 24

Description

  • I manually remove the problematic segment
  • I also remove an unnecessary coordinate at the end of the path

@github-actions github-actions bot added the update icon/data Issues or pull requests regarding icons that are outdated, this can be the SVG or color or both label Mar 5, 2021
@service-paradis service-paradis mentioned this pull request Mar 5, 2021
69 tasks
Copy link
Member

@adamrusted adamrusted left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seeing some differences between your PR (black) and the source icon (red) here - any chance you could look to rebuild it?

@service-paradis
Copy link
Member Author

Seeing some differences between your PR (black) and the source icon (red) here - any chance you could look to rebuild it?

Good catch! I started from scratch this time! :)

@PeterShaggyNoble
Copy link
Member

This does not look like a fun icon to work on so sorry about this! I'm seeing a small difference in the right eyeball (your version in red) and an even smaller one at the top of the intersection between the tail & the pencil.

Also, could you update the source to https://github.com/notepad-plus-plus/notepad-plus-plus/blob/1f2c63cce173e3e1dc5922637c81a851693e2856/PowerEditor/misc/chameleon/chameleon-pencil.eps?

@service-paradis
Copy link
Member Author

This does not look like a fun icon to work on so sorry about this! I'm seeing a small difference in the right eyeball (your version in red) and an even smaller one at the top of the intersection between the tail & the pencil.

haha, surely not a fun one 😃, but thanks for the review. I will check this out!

Also, could you update the source to https://github.com/notepad-plus-plus/notepad-plus-plus/blob/1f2c63cce173e3e1dc5922637c81a851693e2856/PowerEditor/misc/chameleon/chameleon-pencil.eps?

Sure!

@service-paradis
Copy link
Member Author

Just gave it another try. Let me know if there is something else!

Copy link
Member

@adamrusted adamrusted left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are a couple of tiny differences between source (black) and PR (red) - though it looks like they'll almost certainly be down to optimization. Other than those, the icon is perfect - and I'd be happy to merge if another @simple-icons/maintainers okays the tiny differences.

@fbernhart
Copy link
Contributor

LGTM 👍🏼 Thanks @service-paradis

@fbernhart fbernhart merged commit 2f6cf1a into simple-icons:develop Mar 13, 2021
ericcornelissen added a commit that referenced this pull request Mar 14, 2021
# New Icons

- Amazon S3 (#4999)
- Commerzbank (#5028)
- DatoCMS (#5184)
- Enpass (#5174)
- Hyper (#5197)
- Mercurial (#5157)
- Pointy (#4952)
- Private Internet Access (#5158)
- Stimulus (#5209)
- SymPy (#4554)
- XState (#4971)

# Updated Icons

- AlliedModders (#5107)
- Code Climate (#5194)
- Elsevier (#5175)
- Firefox (#5203)
- Git (#5213)
- Google Ads (#4471)
- Monzo (#5219)
- Notepad++ (#5187)
- pre-commit (#5226)
- SparkFun (#5196)
- Stack Overflow (#5217)
@service-paradis service-paradis deleted the update-notepadplusplus branch March 14, 2021 17:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
update icon/data Issues or pull requests regarding icons that are outdated, this can be the SVG or color or both
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants