Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Enpass #5174

Merged
merged 1 commit into from Mar 13, 2021
Merged

Add Enpass #5174

merged 1 commit into from Mar 13, 2021

Conversation

PeterShaggyNoble
Copy link
Member

@PeterShaggyNoble PeterShaggyNoble commented Mar 4, 2021

Enpass

Issue: Resolves #4941
Alexa rank: ~90.1k

Checklist

  • I updated the JSON data in _data/simple-icons.json
  • I optimized the icon with SVGO or SVGOMG
  • The SVG viewbox is 0 0 24 24

Description

Icon from SVG in this zip, colour from logo found in source header after scrolling.
Icon & colour from SVG in source header as the ones available for download are pretty bad and, therefore, I figured, slightly outdated.

@PeterShaggyNoble PeterShaggyNoble added the new icon Issues or pull requests for adding a new icon label Mar 4, 2021
@fbernhart
Copy link
Contributor

@PeterShaggyNoble I can see a difference in the height between your version and the source. Can you double check?

image

@PeterShaggyNoble
Copy link
Member Author

Oop! Sorry, @fbernhart, I forgot to update the description before submitting this PR 🤦🏻‍♂️ I actually based the SVG off the one found in the source header as all the ones they make available for download are riddled with imperfections and excess points so I figured the one on the website was the lesser of 2 evils here. Vertically stretching my version to match the height of the downloadable ones gets us a little closer but there are still a few small differences. Happy to have try another pass at this with one of the other versions, though, if you think that's the way we should go.

@fbernhart
Copy link
Contributor

@PeterShaggyNoble Oh, ok. I didn't know that you've taken the one from the header. Previously I've compared your PR against the SVGs in the press kit.

Comparing your PR against the SVG in the header actually matches perfectly! 🏅 So let's merge it.

@fbernhart fbernhart merged commit f2803c2 into simple-icons:develop Mar 13, 2021
ericcornelissen added a commit that referenced this pull request Mar 14, 2021
# New Icons

- Amazon S3 (#4999)
- Commerzbank (#5028)
- DatoCMS (#5184)
- Enpass (#5174)
- Hyper (#5197)
- Mercurial (#5157)
- Pointy (#4952)
- Private Internet Access (#5158)
- Stimulus (#5209)
- SymPy (#4554)
- XState (#4971)

# Updated Icons

- AlliedModders (#5107)
- Code Climate (#5194)
- Elsevier (#5175)
- Firefox (#5203)
- Git (#5213)
- Google Ads (#4471)
- Monzo (#5219)
- Notepad++ (#5187)
- pre-commit (#5226)
- SparkFun (#5196)
- Stack Overflow (#5217)
@PeterShaggyNoble PeterShaggyNoble deleted the add/enpass branch March 15, 2021 10:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new icon Issues or pull requests for adding a new icon
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Request: Enpass
2 participants