Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add DatoCMS icon #5184

Merged
merged 1 commit into from
Mar 7, 2021
Merged

Conversation

service-paradis
Copy link
Member

image

Issue: N/A
Alexa rank: ~100k

Checklist

  • I updated the JSON data in _data/simple-icons.json
  • I optimized the icon with SVGO or SVGOMG
  • The SVG viewbox is 0 0 24 24

Description

@github-actions github-actions bot added the new icon Issues or pull requests for adding a new icon label Mar 5, 2021
Copy link
Member

@mondeja mondeja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm seeing a minor difference of width between your version (23,848 px) and the source (23,647px), that could be due the optimization process. Would you min to check that @service-paradis?

@service-paradis
Copy link
Member Author

I'm seeing a minor difference of width between your version (23,848 px) and the source (23,647px), that could be due the optimization process. Would you min to check that @service-paradis?

Which file are you comparing to? I used Only icon/Black/black_d_icon.svg to create it. I'm not able to see the difference in width using this one in Inkscape:
image

Copy link
Member

@mondeja mondeja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, I was using another source to compare against.
It is perfect 💯 Thank you @service-paradis 🙏

@mondeja mondeja merged commit 5f3b6f7 into simple-icons:develop Mar 7, 2021
@service-paradis
Copy link
Member Author

No problem, thank you 😃

@service-paradis service-paradis deleted the add-datocms branch March 7, 2021 19:35
ericcornelissen added a commit that referenced this pull request Mar 14, 2021
# New Icons

- Amazon S3 (#4999)
- Commerzbank (#5028)
- DatoCMS (#5184)
- Enpass (#5174)
- Hyper (#5197)
- Mercurial (#5157)
- Pointy (#4952)
- Private Internet Access (#5158)
- Stimulus (#5209)
- SymPy (#4554)
- XState (#4971)

# Updated Icons

- AlliedModders (#5107)
- Code Climate (#5194)
- Elsevier (#5175)
- Firefox (#5203)
- Git (#5213)
- Google Ads (#4471)
- Monzo (#5219)
- Notepad++ (#5187)
- pre-commit (#5226)
- SparkFun (#5196)
- Stack Overflow (#5217)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new icon Issues or pull requests for adding a new icon
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants