-
-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add XState #4971
Add XState #4971
Conversation
Thanks for taking this one on, @Neo42. The linting is failing because you need to combine the 2 Can you also please complete the PR template and update the source to https://github.com/davidkpiano/xstate/blob/544df7f00e2ef49603b5e5ff2f0d183ff6bd5e7c/docs/.vuepress/public/logo.svg? |
Cool. Thanks for the hint, @PeterShaggyNoble. First time doing svg editing. Harder than I thought. |
Don't worry, we're here to help 🙂 Thanks for the update. However, your version (in red below) is slightly misaligned but that's most likely down to the precision being too low, could you have another look at that please? For the colour, I'm getting Finally, you might want to double check the |
Are you still working on this one, @Neo42? |
Sorry @PeterShaggyNoble, I couldn't make time for this. Just give me this week and hopefully I can get it fixed. |
Should be fine now @PeterShaggyNoble. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All looks perfect to me now, @Neo42 👍🏻 Thanks for your work on this one.
The more I look at their site, though, the less sure I become of the colour choice! 😆 But I'll merge this in as-is and we can update the colour later, if necessary.
Thanks to you, too, @PeterShaggyNoble. Will submit again at some time. Next time shouldn't be so tricky. |
# New Icons - Amazon S3 (#4999) - Commerzbank (#5028) - DatoCMS (#5184) - Enpass (#5174) - Hyper (#5197) - Mercurial (#5157) - Pointy (#4952) - Private Internet Access (#5158) - Stimulus (#5209) - SymPy (#4554) - XState (#4971) # Updated Icons - AlliedModders (#5107) - Code Climate (#5194) - Elsevier (#5175) - Firefox (#5203) - Git (#5213) - Google Ads (#4471) - Monzo (#5219) - Notepad++ (#5187) - pre-commit (#5226) - SparkFun (#5196) - Stack Overflow (#5217)
Issue: Closes #4965
Alexa rank: 328744
Checklist
_data/simple-icons.json
viewbox
is0 0 24 24
Description
Hex value was grabbed from XState's official stylesheet by @PeterShaggyNoble.
The logo was cropped with Inkscape, centered with icomoon and scaled with SVG Path Editor, which is pretty easy to use. Highly recommended tools. (Just to keep a record for my own use)