Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add XState #4971

Merged
merged 10 commits into from
Mar 10, 2021
Merged

Add XState #4971

merged 10 commits into from
Mar 10, 2021

Conversation

Neo42
Copy link
Contributor

@Neo42 Neo42 commented Feb 11, 2021

XState

Issue: Closes #4965
Alexa rank: 328744

Checklist

  • I updated the JSON data in _data/simple-icons.json
  • I optimized the icon with SVGO or SVGOMG
  • The SVG viewbox is 0 0 24 24

Description

Hex value was grabbed from XState's official stylesheet by @PeterShaggyNoble.
The logo was cropped with Inkscape, centered with icomoon and scaled with SVG Path Editor, which is pretty easy to use. Highly recommended tools. (Just to keep a record for my own use)

@github-actions github-actions bot added the new icon Issues or pull requests for adding a new icon label Feb 11, 2021
@Neo42 Neo42 closed this Feb 11, 2021
@Neo42 Neo42 reopened this Feb 11, 2021
@PeterShaggyNoble
Copy link
Member

Thanks for taking this one on, @Neo42. The linting is failing because you need to combine the 2 paths into 1, optimise that path and remove all newlines & tabs from the SVG.

Can you also please complete the PR template and update the source to https://github.com/davidkpiano/xstate/blob/544df7f00e2ef49603b5e5ff2f0d183ff6bd5e7c/docs/.vuepress/public/logo.svg?

@Neo42
Copy link
Contributor Author

Neo42 commented Feb 11, 2021

Cool. Thanks for the hint, @PeterShaggyNoble. First time doing svg editing. Harder than I thought.

@Neo42 Neo42 marked this pull request as ready for review February 11, 2021 15:10
@Neo42 Neo42 changed the title Update simple-icons.json for XState Add icon for XState Feb 11, 2021
@Neo42 Neo42 changed the title Add icon for XState Add XState Feb 11, 2021
@PeterShaggyNoble
Copy link
Member

First time doing svg editing. Harder than I thought.

Don't worry, we're here to help 🙂

Thanks for the update. However, your version (in red below) is slightly misaligned but that's most likely down to the precision being too low, could you have another look at that please?

For the colour, I'm getting #000000 from the website's logo but I do still think we should go with the #2c3e50 from the website's stylesheet.

Finally, you might want to double check the source entry in the JSON file 😉

@PeterShaggyNoble
Copy link
Member

Are you still working on this one, @Neo42?

@Neo42
Copy link
Contributor Author

Neo42 commented Mar 4, 2021

Sorry @PeterShaggyNoble, I couldn't make time for this. Just give me this week and hopefully I can get it fixed.

@Neo42
Copy link
Contributor Author

Neo42 commented Mar 8, 2021

Should be fine now @PeterShaggyNoble.

Copy link
Member

@PeterShaggyNoble PeterShaggyNoble left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All looks perfect to me now, @Neo42 👍🏻 Thanks for your work on this one.

The more I look at their site, though, the less sure I become of the colour choice! 😆 But I'll merge this in as-is and we can update the colour later, if necessary.

@PeterShaggyNoble PeterShaggyNoble merged commit 42bbc47 into simple-icons:develop Mar 10, 2021
@Neo42
Copy link
Contributor Author

Neo42 commented Mar 10, 2021

Thanks to you, too, @PeterShaggyNoble. Will submit again at some time. Next time shouldn't be so tricky.

ericcornelissen added a commit that referenced this pull request Mar 14, 2021
# New Icons

- Amazon S3 (#4999)
- Commerzbank (#5028)
- DatoCMS (#5184)
- Enpass (#5174)
- Hyper (#5197)
- Mercurial (#5157)
- Pointy (#4952)
- Private Internet Access (#5158)
- Stimulus (#5209)
- SymPy (#4554)
- XState (#4971)

# Updated Icons

- AlliedModders (#5107)
- Code Climate (#5194)
- Elsevier (#5175)
- Firefox (#5203)
- Git (#5213)
- Google Ads (#4471)
- Monzo (#5219)
- Notepad++ (#5187)
- pre-commit (#5226)
- SparkFun (#5196)
- Stack Overflow (#5217)
@Neo42 Neo42 deleted the Neo42-patch-1 branch April 11, 2021 01:57
@Neo42 Neo42 mentioned this pull request Apr 11, 2021
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new icon Issues or pull requests for adding a new icon
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Icon request for XState
2 participants