Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added SymPy #4554

Merged
merged 1 commit into from
Mar 8, 2021
Merged

Added SymPy #4554

merged 1 commit into from
Mar 8, 2021

Conversation

adamrusted
Copy link
Member

sympy

Issue: Closes #3324
Alexa rank: 225,126

Checklist

  • I updated the JSON data in _data/simple-icons.json
  • I optimized the icon with SVGO or SVGOMG
  • The SVG viewbox is 0 0 24 24

Description

This was a fun one! 馃く
SVG taken from source and shapes simplified as much as possible, with outline of snake being used to differentiate between snake and cube.

@github-actions github-actions bot added the new icon Issues or pull requests for adding a new icon label Jan 1, 2021
@PeterShaggyNoble
Copy link
Member

PeterShaggyNoble commented Mar 1, 2021

Oh, this one is an absolute jerk! 馃槷 I remember trying it myself a few months back and tearing my hair out!

Seeing quite a few differences, I'm afraid 馃檨 Might give it another try myself later to try to help you out but I seem to remember Inkscape not liking the strokes in the source file at all.

image

@adamrusted
Copy link
Member Author

@PeterShaggyNoble I think some of the problem is that I've gone with the 'inner paths' of the cube and the snake, instead of the outer strokes - so that'll throw off any comparison by a bit.

@PeterShaggyNoble
Copy link
Member

Ah, yes, the strokes may have been throwing off my comparison. Removing them from the left panel gets me a little closer and from the top panel, too, slightly closer still but neither quite perfect. And, thanks to Inkscape completely butchering pretty much all the strokes when converting them to paths (it can't even handle the tongue!), I'm unable to recreate it myself so that I'm at least comparing like with like. I think we'll need one of the other @simple-icons/maintainers with better software to throw an eye over this one.

Copy link
Member

@mondeja mondeja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm able to fit this perfectly with the source. Altough the circles may be subject to interpretation, I think the chosen treatment is a good compromise.

Merging this as is. Nice work @adamrusted 馃憣

@mondeja mondeja merged commit 1854f7a into simple-icons:develop Mar 8, 2021
@adamrusted adamrusted deleted the SymPy branch March 8, 2021 13:19
ericcornelissen added a commit that referenced this pull request Mar 14, 2021
# New Icons

- Amazon S3 (#4999)
- Commerzbank (#5028)
- DatoCMS (#5184)
- Enpass (#5174)
- Hyper (#5197)
- Mercurial (#5157)
- Pointy (#4952)
- Private Internet Access (#5158)
- Stimulus (#5209)
- SymPy (#4554)
- XState (#4971)

# Updated Icons

- AlliedModders (#5107)
- Code Climate (#5194)
- Elsevier (#5175)
- Firefox (#5203)
- Git (#5213)
- Google Ads (#4471)
- Monzo (#5219)
- Notepad++ (#5187)
- pre-commit (#5226)
- SparkFun (#5196)
- Stack Overflow (#5217)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new icon Issues or pull requests for adding a new icon
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add SymPy Icon
4 participants