Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Code Climate #5194

Merged
merged 2 commits into from Mar 11, 2021
Merged

Update Code Climate #5194

merged 2 commits into from Mar 11, 2021

Conversation

mondeja
Copy link
Member

@mondeja mondeja commented Mar 7, 2021 •
edited

image

Issue: #4590
Alexa rank: ~97K

Checklist

  • I updated the JSON data in _data/simple-icons.json
  • I optimized the icon with SVGO or SVGOMG
  • The SVG viewbox is 0 0 24 24

Description

  • Rebuilt from scratch using the SVG of the header of their website (same source) fixing the mountain below because it has imperfect straight lines.

@github-actions github-actions bot added the update icon/data Issues or pull requests regarding icons that are outdated, this can be the SVG or color or both label Mar 7, 2021
@mondeja mondeja mentioned this pull request Mar 7, 2021
Closed
69 tasks
@PeterShaggyNoble
Copy link
Member

There are a few icon sized versions without the imperfection available at https://codeclimate.com/github/codeclimate/python-test-reporter/badges/, @mondeja, could you update from one of those?

@mondeja
Copy link
Member Author

mondeja commented Mar 8, 2021

Where @PeterShaggyNoble? I can't see one with straight lines in that page... 🤔

@PeterShaggyNoble
Copy link
Member

It's in this badge, @mondeja.

@mondeja
Copy link
Member Author

mondeja commented Mar 10, 2021

Updated with that source ✏️

adamrusted
adamrusted requested changes Mar 11, 2021
View reviewed changes
Copy link
Member

@adamrusted adamrusted left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @mondeja 💪 - though I'm seeing some pretty severe differences between PR (red) and source (black) after removing the weird points in the left-hand shape of the source. Any chance you could take another look at it? 😅

Re-reviewing from the badges SVG.

adamrusted
adamrusted approved these changes Mar 11, 2021
View reviewed changes
Copy link
Member

@adamrusted adamrusted left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When I updated my source to the SVG badge you've updated the source to 🙄 it matches up perfectly. Note to self, read the whole thread when reviewing an icon! 😆

Thanks @mondeja for your work on this one 🚀

@adamrusted adamrusted merged commit e9fb9bc into simple-icons:develop Mar 11, 2021
@github-actions github-actions bot mentioned this pull request Mar 14, 2021
Merged
ericcornelissen added a commit that referenced this pull request Mar 14, 2021
@ericcornelissen
Release 11 new icons and 11 updated icons (v4.15.0)
0095133 
# New Icons

- Amazon S3 (#4999)
- Commerzbank (#5028)
- DatoCMS (#5184)
- Enpass (#5174)
- Hyper (#5197)
- Mercurial (#5157)
- Pointy (#4952)
- Private Internet Access (#5158)
- Stimulus (#5209)
- SymPy (#4554)
- XState (#4971)

# Updated Icons

- AlliedModders (#5107)
- Code Climate (#5194)
- Elsevier (#5175)
- Firefox (#5203)
- Git (#5213)
- Google Ads (#4471)
- Monzo (#5219)
- Notepad++ (#5187)
- pre-commit (#5226)
- SparkFun (#5196)
- Stack Overflow (#5217)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adamrusted adamrusted adamrusted approved these changes

Assignees
No one assigned
Labels
update icon/data Issues or pull requests regarding icons that are outdated, this can be the SVG or color or both
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@mondeja @PeterShaggyNoble @adamrusted