Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Stack Overflow #5217

Merged

Conversation

PeterShaggyNoble
Copy link
Member

@PeterShaggyNoble PeterShaggyNoble commented Mar 10, 2021

Stack Overflow

Issue: n/a
Alexa rank: 51

Checklist

  • I updated the JSON data in _data/simple-icons.json
  • I optimized the icon with SVGO or SVGOMG
  • The SVG viewbox is 0 0 24 24

Description

Icon from this SVG, which show some differences to our current version. Our current version also has some unnecessary points. A possible alternative source could be one of the smaller, icon sized LogoGlyph files available here, which are considerably different to the logo I used. Edited to add: If we do choose to use one of those icons instead then our Stack Exchange icon will need to be updated to match as well.

Colour is from the same source SVG but a possible alternative could be the insignificantly different #f48024, which is the --theme-primary-color variable found in their website's stylesheet.

@PeterShaggyNoble PeterShaggyNoble added the update icon/data Issues or pull requests regarding icons that are outdated, this can be the SVG or color or both label Mar 10, 2021
@fbernhart
Copy link
Contributor

LGTM 👍🏼 Thanks @PeterShaggyNoble

@fbernhart fbernhart merged commit 62afc4e into simple-icons:develop Mar 13, 2021
ericcornelissen added a commit that referenced this pull request Mar 14, 2021
# New Icons

- Amazon S3 (#4999)
- Commerzbank (#5028)
- DatoCMS (#5184)
- Enpass (#5174)
- Hyper (#5197)
- Mercurial (#5157)
- Pointy (#4952)
- Private Internet Access (#5158)
- Stimulus (#5209)
- SymPy (#4554)
- XState (#4971)

# Updated Icons

- AlliedModders (#5107)
- Code Climate (#5194)
- Elsevier (#5175)
- Firefox (#5203)
- Git (#5213)
- Google Ads (#4471)
- Monzo (#5219)
- Notepad++ (#5187)
- pre-commit (#5226)
- SparkFun (#5196)
- Stack Overflow (#5217)
@PeterShaggyNoble PeterShaggyNoble deleted the update/stackoverflow branch March 15, 2021 10:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
update icon/data Issues or pull requests regarding icons that are outdated, this can be the SVG or color or both
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants