Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update AlliedModders #5107

Merged
merged 4 commits into from Mar 8, 2021

Conversation

PeterShaggyNoble
Copy link
Member

@PeterShaggyNoble PeterShaggyNoble commented Feb 23, 2021

AlliedModders

Issue: #1893
Alexa rank: ~63.4k

Checklist

  • I updated the JSON data in _data/simple-icons.json
  • I optimized the icon with SVGO or SVGOMG
  • The SVG viewbox is 0 0 24 24

Description

Icon from this SVG.

Possible alternative treatment:

@PeterShaggyNoble PeterShaggyNoble added the update icon/data Issues or pull requests regarding icons that are outdated, this can be the SVG or color or both label Feb 23, 2021
@adamrusted
Copy link
Member

adamrusted commented Feb 25, 2021

Ooh, I like the alternative path!
Will ping other @simple-icons/maintainers for opinions though, as both seem to be a little unclear at the smaller shields.io sizes in the preview. Which do we think would work better for most users?

@PeterShaggyNoble PeterShaggyNoble added the in discussion There is an ongoing discussion that should be finished before we can continue label Feb 25, 2021
@fbernhart
Copy link
Contributor

Another alternative: Removing the stroke and just keeping the blue fill.

am-banner

@adamrusted
Copy link
Member

I think if we were to do a 'filled' logo, we'd have to keep the stroke on there to maintain the rounded edges - otherwise I think it's a solid option @fbernhart. I think of the 3, that'd be my preferred option - purely for readability on a smaller scale.

@PeterShaggyNoble
Copy link
Member Author

PeterShaggyNoble commented Mar 2, 2021

Including the stroke in the filled version doesn't work quite as well. Seeing as we have a few seemingly equally viable options, let's take it to a quick straw poll by giving a 👍🏻 to

@mondeja
Copy link
Member

mondeja commented Mar 7, 2021

Given that most of us have voted for the alternative version in the comment #5107 (comment), could you go with that @PeterShaggyNoble?

@PeterShaggyNoble PeterShaggyNoble removed help wanted in discussion There is an ongoing discussion that should be finished before we can continue labels Mar 8, 2021
@PeterShaggyNoble
Copy link
Member Author

Thanks, @mondeja - updated.

Copy link
Member

@mondeja mondeja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks perfect 💯 Thank you @PeterShaggyNoble 🙏

@mondeja mondeja merged commit ecff956 into simple-icons:develop Mar 8, 2021
@PeterShaggyNoble PeterShaggyNoble deleted the update/alliedmodders branch March 8, 2021 16:17
ericcornelissen added a commit that referenced this pull request Mar 14, 2021
# New Icons

- Amazon S3 (#4999)
- Commerzbank (#5028)
- DatoCMS (#5184)
- Enpass (#5174)
- Hyper (#5197)
- Mercurial (#5157)
- Pointy (#4952)
- Private Internet Access (#5158)
- Stimulus (#5209)
- SymPy (#4554)
- XState (#4971)

# Updated Icons

- AlliedModders (#5107)
- Code Climate (#5194)
- Elsevier (#5175)
- Firefox (#5203)
- Git (#5213)
- Google Ads (#4471)
- Monzo (#5219)
- Notepad++ (#5187)
- pre-commit (#5226)
- SparkFun (#5196)
- Stack Overflow (#5217)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
update icon/data Issues or pull requests regarding icons that are outdated, this can be the SVG or color or both
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants