Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Adobe XD #3386

Merged
merged 6 commits into from
Jan 3, 2021
Merged

Update Adobe XD #3386

merged 6 commits into from
Jan 3, 2021

Conversation

MetLee
Copy link
Contributor

@MetLee MetLee commented Jul 30, 2020 •
edited

image

Issue: #3369
Alexa rank:

Checklist

  • I updated the JSON data in _data/simple-icons.json
  • I optimized the icon with SVGO or SVGOMG
  • The SVG viewbox is 0 0 24 24

Description

@PeterShaggyNoble PeterShaggyNoble added update icon/data Issues or pull requests regarding icons that are outdated, this can be the SVG or color or both pending Issues that are pending because of e.g. a scheduled brand update labels Jul 31, 2020
@PeterShaggyNoble PeterShaggyNoble mentioned this pull request Jul 31, 2020
Closed
10 tasks
@PeterShaggyNoble PeterShaggyNoble removed the pending Issues that are pending because of e.g. a scheduled brand update label Aug 4, 2020
PeterShaggyNoble
PeterShaggyNoble requested changes Aug 4, 2020
View reviewed changes
Copy link
Member

@PeterShaggyNoble PeterShaggyNoble left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you double check this one, @MetLee? I'm seeing some hairline differences in the letters when compared to https://www.adobe.com/content/dam/cc/icons/xd.svg - the top-right arm of the X and the curve of the d, for example.

@fbernhart
Copy link
Contributor

@MetLee Thanks for your work so far. Are you still working on this one?

image

If so, it seems like Adobe has slightly changed their logo in the meantime and changed the rounded edges (see comparison above with your version in red).

Could you update your pull request with the logo provided here as source?
https://www.adobe.com/content/dam/cc/us/en/products/xd/home/XD_lockup.svg

@fbernhart fbernhart added the awaiting reply Issues or pull requests awaiting reply from an individual before it may be addressed label Dec 15, 2020
@adamrusted
Copy link
Member

Just to weigh in on this:

Can you double check this one, @MetLee? I'm seeing some hairline differences in the letters when compared to adobe.com/content/dam/cc/icons/xd.svg

This is the current icon as used on the UI/UX page of Adobe.

Comparing @MetLee's icon and my own generated from source, I can't see any differences between them. I've provided my path below, and providing the source is updated to the correct used SVG this one in my case, then this is good to merge IMO.

M19.75.3H4.25C1.9.3 0 2.2 0 4.55v14.9c0 2.35 1.9 4.25 4.25 4.25h15.5c2.35 0 4.25-1.9 4.25-4.25V4.55C24 2.2 22.1.3 19.75.3zm-6.91 16.47c-.01.04-.05.01-.11.02h-2.29c-.16 0-.27-.01-.34-.11-.21-.42-.43-.83-.64-1.25-.21-.41-.44-.83-.68-1.26-.24-.43-.48-.86-.72-1.3h-.02c-.21.43-.44.86-.67 1.29-.23.43-.46.86-.68 1.28-.23.42-.46.85-.69 1.26-.04.1-.12.11-.23.11h-2.2c-.04 0-.07.02-.07-.03-.01-.04 0-.08.02-.11l3.11-5.1L3.6 6.44c-.03-.04-.04-.08-.02-.1.02-.03.06-.04.1-.04h2.27c.05 0 .1.01.14.02.04.02.07.05.1.09.19.43.41.86.64 1.29.24.43.47.85.72 1.27.24.42.46.84.67 1.27h.02c.21-.44.43-.87.65-1.29.22-.42.45-.84.68-1.26.23-.42.45-.85.67-1.26.01-.04.03-.08.06-.1.04-.02.08-.03.13-.02h2.11c.05-.01.1.02.11.07.01.01-.01.05-.03.07l-3 4.95 3.2 5.25c.02.04.03.08.02.12zm7.57-.39c-.52.22-1.07.38-1.63.48-.51.09-1.02.14-1.54.14-.74.01-1.48-.14-2.15-.45-.63-.29-1.15-.77-1.51-1.36-.37-.61-.55-1.37-.55-2.28-.01-.74.18-1.47.55-2.11.38-.65.93-1.19 1.59-1.55.7-.39 1.54-.58 2.53-.58.05 0 .12 0 .21.01s.19.01.31.02V5.54c0-.07.03-.11.1-.11h2.03c.05-.01.09.03.1.07v9.54c0 .18.01.38.02.6.02.21.03.41.04.58 0 .07-.03.13-.1.16zm-2.46-5.83c.09.01.18.03.27.05V15c-.12.04-.23.06-.36.05-.13.01-.27.02-.42.02-.28 0-.56-.04-.83-.13-.26-.08-.49-.22-.68-.4-.2-.2-.35-.44-.45-.71-.12-.33-.18-.68-.17-1.03 0-.52.11-.95.33-1.27.22-.32.51-.57.85-.74.35-.18.74-.26 1.13-.26.11 0 .22.01.33.02z

Could you update your pull request with the logo provided here as source?
adobe.com/content/dam/cc/us/en/products/xd/home/XD_lockup.svg

Does have some differences to the above path, but only appears to be used in the 'lockup' variation of the icon.

@adamrusted adamrusted added in discussion There is an ongoing discussion that should be finished before we can continue and removed awaiting reply Issues or pull requests awaiting reply from an individual before it may be addressed changes requested labels Jan 1, 2021
@adamrusted adamrusted removed the in discussion There is an ongoing discussion that should be finished before we can continue label Jan 3, 2021
@adamrusted
Copy link
Member

@simple-icons/maintainers - this one is ready for review! 🙏🏻

@fbernhart
Copy link
Contributor

@adamrusted We've used "https://www.adobe.com/products/PRODUCTNAME" as source for most of the other Adobe logos (After Effects, Dreamweaver, Illustrator, InDesign, Lightroom, Lightroom Classic, Photoshop, Premiere Pro). For consistency I think we should stick with that and use https://www.adobe.com/products/xd.html instead. Do you agree?

@adamrusted
Copy link
Member

@adamrusted We've used "adobe.com/products/PRODUCTNAME" as source for most of the other Adobe logos (After Effects, Dreamweaver, Illustrator, InDesign, Lightroom, Lightroom Classic, Photoshop, Premiere Pro). For consistency I think we should stick with that and use adobe.com/products/xd.html instead. Do you agree?

Sure, let me push a quick edit - and it'll be good to go!

@fbernhart
Copy link
Contributor

@adamrusted Thanks. But now that we've agreed on the source, the differences in #3386 (comment) apply.

@MetLee Thanks for your work so far. Are you still working on this one?

image

If so, it seems like Adobe has slightly changed their logo in the meantime and changed the rounded edges (see comparison above with your version in red).

Could you update your pull request with the logo provided here as source?
https://www.adobe.com/content/dam/cc/us/en/products/xd/home/XD_lockup.svg

Could you rebuilt it with the SVG found on the https://www.adobe.com/products/xd.html page?

@fbernhart
Copy link
Contributor

@adamrusted Thanks! LGTM 👍🏼

And as well thanks to @MetLee for the initial work on this icon! 🎉

@fbernhart fbernhart merged commit e02a846 into simple-icons:develop Jan 3, 2021
@github-actions github-actions bot mentioned this pull request Jan 10, 2021
Merged
ericcornelissen added a commit that referenced this pull request Jan 10, 2021
@ericcornelissen
Release 103 new icons and 41 updated icons (v4.6.0)
701d605 
# New Icons

- 3M (#3631)
- Accenture (#4396)
- AIOHTTP (#4536)
- AniList (#4609)
- AnyDesk (#4663)
- Apache JMeter (#4594)
- Apache Kylin (#4545)
- ARK Ecosystem (#4699)
- B&R Automation (#4552)
- bigbasket (#4572, #4616)
- Bugcrowd (#4615)
- CheckiO (#4512)
- Chrysler (#4357)
- Cloudways (#3352)
- Cockroach Labs (#4665)
- CodeProject (#4617)
- CodinGame (#4575)
- Cognizant (#4392)
- Contentful (#4537)
- Cookiecutter (#3649)
- DataStax (#4393)
- De'Longhi (#4426)
- Deepnote (#4546)
- Digi-Key Electronics (#4398)
- Eclipse Vert.x (#4631)
- edX (#4452)
- egghead (#4644)
- Eight Sleep (#3638)
- Facepunch (#3671)
- FedEx (#4564)
- Fortran (#4397)
- FreeNAS (#4573)
- Gitee (#4625)
- Google Domains (#4622)
- Google Photos (#4341)
- Grubhub (#4544)
- Homebridge (#4607)
- Hyperledger (#4673)
- IKEA (#4555)
- Ingress (#3389)
- Jitsi (#4540)
- Kitsu (#4520)
- Klook (#4548)
- Lada (#4361)
- Lichess (#3535)
- Linktree (#4662)
- Looker (#4442)
- McLaren (#4538)
- MetaFilter (#4547)
- Motorola (#3425)
- Noun Project (#4608)
- Observable (#4640)
- Open Bug Bounty (#4627)
- Open Nebula (#4551)
- OpenCV (#4580)
- PageSpeed Insights (#4553)
- Paytm (#4643)
- pfSense (#4671)
- Pop!_OS (#3769)
- Progate (#3680)
- Progress (#4611)
- PyPy (#4281)
- Racket (#3483)
- Radar (#4319)
- Rainmeter (#3554)
- Reliance Industries Limited (#4702)
- Revue (#4391)
- ROS (#4658)
- SciPy (#3772)
- Scrimba (#4556)
- SEPA (#3154)
- SoloLearn (#4624)
- Spark AR (#4468)
- Speedtest (#4626)
- STARZ (#4612)
- Streamlit (#4412)
- Swiper (#4562)
- São Paulo Metro (#4570)
- tado° (#4637)
- TaxBuzz (#4619)
- Testin (#4571)
- Testing Library (#4542)
- ThinkPad (#4550)
- Ticketmaster (#4526)
- Tile (#4614)
- tmux (#3512)
- Treyarch (#4690)
- TrueNAS (#4574)
- Unraid (#4613)
- UPS (#4565)
- USPS (#4549)
- Vault (#4606)
- Vimeo Livestream (#4703)
- Webflow (#4568)
- Weights & Biases (#4630)
- Wikiquote (#4687)
- Winmate (#3316)
- Wipro (#4359)
- Xilinx (#3424)
- Zelle (#4605)
- Zoho (#3661)
- Zomato (#4664)
- Zotero (#4561)

# Updated Icons

- Adobe XD (#3386)
- Amazon Lumberyard (#4591)
- Andela (#4592)
- Apache Maven (#4593)
- Daimler (#4618)
- DigitalOcean (#4648)
- Fossa (#4473)
- Gatsby (#4620)
- GIPHY (#4621)
- Google (#4508)
- Google Analytics (#4504)
- Google Cardboard (#4058)
- Google Fit (#4506)
- Harbor (#4598)
- Jira Software (#4657)
- Kahoot! (#4635)
- Kotlin (#4485)
- Kyocera (#4475)
- Lenovo (#4477)
- Material Design Icons (#4642)
- Mozilla (#4656)
- pr.co (#4655)
- SonicWall (#4654)
- StackPath (#4652)
- Stadia (#4503)
- Synology (#4220)
- TED (#4653)
- Trustpilot (#4481)
- Uber (#4650)
- Uber Eats (#4651)
- Udacity (#4596)
- Viber (#4597)
- Waze (#4583)
- Wish (#4482)
- WP Engine (#4639)
- XMPP (#4483)
- YouTube (#4582)
- YouTube Studio (#4581)
- YouTube TV (#4405)
- Zendesk (#4595)
- Zillow (#4636)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PeterShaggyNoble PeterShaggyNoble PeterShaggyNoble requested changes

Assignees
No one assigned
Labels
update icon/data Issues or pull requests regarding icons that are outdated, this can be the SVG or color or both
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@MetLee @fbernhart @adamrusted @PeterShaggyNoble