Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Racket icon #3483

Merged
merged 5 commits into from
Jan 4, 2021
Merged

Add Racket icon #3483

merged 5 commits into from
Jan 4, 2021

Conversation

spdegabrielle
Copy link
Contributor

image

Issue:
Name: Racket
Alexa rank: 384,283

Checklist

  • I updated the JSON data in _data/simple-icons.json
  • I optimized the icon with SVGO or SVGOMG
  • The SVG viewbox is 0 0 24 24

Description

Hex value from original image on https://racket-lang.org/

Optimised and set role, viewBox, and title as per https://github.com/simple-icons/simple-icons/blob/develop/CONTRIBUTING.md

@spdegabrielle spdegabrielle mentioned this pull request Aug 22, 2020
Closed
@NovaGL
Copy link
Contributor

NovaGL commented Aug 22, 2020

Hi @spdegabrielle

The size of the icon is not correct. I suggest you open it in inkscape and check that the dimensions are 24 x 24 and you can also try increasing the precision in SVGOMG

@spdegabrielle
Copy link
Contributor Author

Sorry I don't have Inkscape

@NovaGL NovaGL linked an issue Aug 23, 2020 that may be closed by this pull request
Racket language icon #3470
Closed
@NovaGL
Copy link
Contributor

NovaGL commented Aug 23, 2020

Thanks fine, use what ever tool you feel comfortable with to fix the problems with the dimensions

@spdegabrielle
Copy link
Contributor Author

Sorry I currently only have access to the online tools listed in the contribution guidance.
Is this something you can help with?

@spdegabrielle
Copy link
Contributor Author

I’m a bit confused @NovaGL
The view box is correct ? How can the image be the wrong size?

<svg role="img" viewBox="0 0 24 24

NovaGL
NovaGL suggested changes Aug 24, 2020
View reviewed changes
Copy link
Contributor

@NovaGL NovaGL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The icons dimensions are outside the viewbox. If you don't want to use Inkscape you'll have to use another program to fix the svg.

The width is 23.995 and the height is 24.009.

@ericcornelissen ericcornelissen added the new icon Issues or pull requests for adding a new icon label Aug 24, 2020
@spdegabrielle
Copy link
Contributor Author

@NovaGL

  • I’m expecting a clipping by less than 1% wont be visible on an icon that when rendered will be less than an inch onscreen even with ‘retina’ displays.
  • I don’t have access to any svg editors.just text editors and the recommended web tools.

@fbernhart fbernhart changed the title Racket icon Add Racket icon Dec 15, 2020
@adamrusted
Copy link
Member

@spdegabrielle I've been able to rebuild this in Adobe Illustrator and pass the linter. Thanks for your work on this one! 🎉

@spdegabrielle
Copy link
Contributor Author

Thank you @adamrusted 😀
You are a star! Happy new year!

@fbernhart
Copy link
Contributor

LGTM! 👍🏼

Thanks @adamrusted and @spdegabrielle for your work!

@fbernhart fbernhart merged commit c131cd6 into simple-icons:develop Jan 4, 2021
@github-actions github-actions bot mentioned this pull request Jan 10, 2021
Merged
ericcornelissen added a commit that referenced this pull request Jan 10, 2021
@ericcornelissen
Release 103 new icons and 41 updated icons (v4.6.0)
701d605 
# New Icons

- 3M (#3631)
- Accenture (#4396)
- AIOHTTP (#4536)
- AniList (#4609)
- AnyDesk (#4663)
- Apache JMeter (#4594)
- Apache Kylin (#4545)
- ARK Ecosystem (#4699)
- B&amp;R Automation (#4552)
- bigbasket (#4572, #4616)
- Bugcrowd (#4615)
- CheckiO (#4512)
- Chrysler (#4357)
- Cloudways (#3352)
- Cockroach Labs (#4665)
- CodeProject (#4617)
- CodinGame (#4575)
- Cognizant (#4392)
- Contentful (#4537)
- Cookiecutter (#3649)
- DataStax (#4393)
- De'Longhi (#4426)
- Deepnote (#4546)
- Digi-Key Electronics (#4398)
- Eclipse Vert.x (#4631)
- edX (#4452)
- egghead (#4644)
- Eight Sleep (#3638)
- Facepunch (#3671)
- FedEx (#4564)
- Fortran (#4397)
- FreeNAS (#4573)
- Gitee (#4625)
- Google Domains (#4622)
- Google Photos (#4341)
- Grubhub (#4544)
- Homebridge (#4607)
- Hyperledger (#4673)
- IKEA (#4555)
- Ingress (#3389)
- Jitsi (#4540)
- Kitsu (#4520)
- Klook (#4548)
- Lada (#4361)
- Lichess (#3535)
- Linktree (#4662)
- Looker (#4442)
- McLaren (#4538)
- MetaFilter (#4547)
- Motorola (#3425)
- Noun Project (#4608)
- Observable (#4640)
- Open Bug Bounty (#4627)
- Open Nebula (#4551)
- OpenCV (#4580)
- PageSpeed Insights (#4553)
- Paytm (#4643)
- pfSense (#4671)
- Pop!_OS (#3769)
- Progate (#3680)
- Progress (#4611)
- PyPy (#4281)
- Racket (#3483)
- Radar (#4319)
- Rainmeter (#3554)
- Reliance Industries Limited (#4702)
- Revue (#4391)
- ROS (#4658)
- SciPy (#3772)
- Scrimba (#4556)
- SEPA (#3154)
- SoloLearn (#4624)
- Spark AR (#4468)
- Speedtest (#4626)
- STARZ (#4612)
- Streamlit (#4412)
- Swiper (#4562)
- São Paulo Metro (#4570)
- tado° (#4637)
- TaxBuzz (#4619)
- Testin (#4571)
- Testing Library (#4542)
- ThinkPad (#4550)
- Ticketmaster (#4526)
- Tile (#4614)
- tmux (#3512)
- Treyarch (#4690)
- TrueNAS (#4574)
- Unraid (#4613)
- UPS (#4565)
- USPS (#4549)
- Vault (#4606)
- Vimeo Livestream (#4703)
- Webflow (#4568)
- Weights &amp; Biases (#4630)
- Wikiquote (#4687)
- Winmate (#3316)
- Wipro (#4359)
- Xilinx (#3424)
- Zelle (#4605)
- Zoho (#3661)
- Zomato (#4664)
- Zotero (#4561)

# Updated Icons

- Adobe XD (#3386)
- Amazon Lumberyard (#4591)
- Andela (#4592)
- Apache Maven (#4593)
- Daimler (#4618)
- DigitalOcean (#4648)
- Fossa (#4473)
- Gatsby (#4620)
- GIPHY (#4621)
- Google (#4508)
- Google Analytics (#4504)
- Google Cardboard (#4058)
- Google Fit (#4506)
- Harbor (#4598)
- Jira Software (#4657)
- Kahoot! (#4635)
- Kotlin (#4485)
- Kyocera (#4475)
- Lenovo (#4477)
- Material Design Icons (#4642)
- Mozilla (#4656)
- pr.co (#4655)
- SonicWall (#4654)
- StackPath (#4652)
- Stadia (#4503)
- Synology (#4220)
- TED (#4653)
- Trustpilot (#4481)
- Uber (#4650)
- Uber Eats (#4651)
- Udacity (#4596)
- Viber (#4597)
- Waze (#4583)
- Wish (#4482)
- WP Engine (#4639)
- XMPP (#4483)
- YouTube (#4582)
- YouTube Studio (#4581)
- YouTube TV (#4405)
- Zendesk (#4595)
- Zillow (#4636)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NovaGL NovaGL NovaGL requested changes

Assignees
No one assigned
Labels
new icon Issues or pull requests for adding a new icon
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Racket language icon
5 participants
@spdegabrielle @NovaGL @adamrusted @fbernhart @ericcornelissen