-
-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Linktree #4662
Add Linktree #4662
Conversation
And remove Zotero JPG
Oops ... Sorry, I didn't notice that there was a JPG file added while reviewing #4561. Thanks for pointing out! 🏆 Makes me wondering if we could add a new rule to the linter, that quickly checks if only SVG files are located in the Some days ago I saw that someone added a LNK file by mistake to their PR. So it seems like stuff like this happens from time to time. |
@PeterShaggyNoble Here is a path with a precision of 3. Feel free to use it.
Sometimes it helps resizing the icon to 23.999 or 24.001 instead before optimizing it. And then after the optimization it will be exactly 24.000. 😊 |
Thanks, @fbernhart. However, I'm seeing a hairline difference at the bottom of the arrowheads when comparing your version (in red) with the original. |
Yes, no harm in doing that, if it's possible - we've all accidentally pasted the wrong file into the wrong directory at some stage! |
This could be added fairly easily to the our-lint script using |
Maybe we could add a rule in .gitignore too to allow only SVG files. Something like:
|
My bad! Sorry guys 😅 |
Perhaps that is a bit easier yes, not a bad idea! (Theoretically this can be circumvented, in contrast to the linter, but that's not something to worry about). Without the intention of hijacking this PR for this disussion, should this go in the root folder's
No problem at all, it happens to the best of us 😄 |
I'd stick it in the root |
@PeterShaggyNoble able to get it down to a precision of 3 by exporting from illustrator with the path being 24.0001px wide and using SVGO. Feel free to use below path: <svg role="img" viewBox="0 0 24 24" xmlns="http://www.w3.org/2000/svg"><title>Linktree icon</title><path d="M7.953 15.066c-.08.163-.08.324-.08.486.08.517.528.897 1.052.89h1.294v4.776c0 .486-.404.89-.89.89H6.577a.898.898 0 0 1-.889-.891v-4.774H.992c-.728 0-1.214-.729-.89-1.377l6.96-12.627a1.065 1.065 0 0 1 1.863 0l2.913 5.585-3.885 7.042zm15.945 0l-6.96-12.627a1.065 1.065 0 0 0-1.862 0l-2.995 5.586 3.885 7.04c.081.164.081.326.081.487-.08.517-.529.897-1.052.89h-1.296v4.776c.005.49.4.887.89.89h2.914a.9.9 0 0 0 .892-.89v-4.775h4.612c.73 0 1.214-.729.89-1.377z"/></svg> |
That works, thanks, @adamrusted. Updated. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Amazing, thanks @PeterShaggyNoble! 🔗🌲
# New Icons - 3M (#3631) - Accenture (#4396) - AIOHTTP (#4536) - AniList (#4609) - AnyDesk (#4663) - Apache JMeter (#4594) - Apache Kylin (#4545) - ARK Ecosystem (#4699) - B&R Automation (#4552) - bigbasket (#4572, #4616) - Bugcrowd (#4615) - CheckiO (#4512) - Chrysler (#4357) - Cloudways (#3352) - Cockroach Labs (#4665) - CodeProject (#4617) - CodinGame (#4575) - Cognizant (#4392) - Contentful (#4537) - Cookiecutter (#3649) - DataStax (#4393) - De'Longhi (#4426) - Deepnote (#4546) - Digi-Key Electronics (#4398) - Eclipse Vert.x (#4631) - edX (#4452) - egghead (#4644) - Eight Sleep (#3638) - Facepunch (#3671) - FedEx (#4564) - Fortran (#4397) - FreeNAS (#4573) - Gitee (#4625) - Google Domains (#4622) - Google Photos (#4341) - Grubhub (#4544) - Homebridge (#4607) - Hyperledger (#4673) - IKEA (#4555) - Ingress (#3389) - Jitsi (#4540) - Kitsu (#4520) - Klook (#4548) - Lada (#4361) - Lichess (#3535) - Linktree (#4662) - Looker (#4442) - McLaren (#4538) - MetaFilter (#4547) - Motorola (#3425) - Noun Project (#4608) - Observable (#4640) - Open Bug Bounty (#4627) - Open Nebula (#4551) - OpenCV (#4580) - PageSpeed Insights (#4553) - Paytm (#4643) - pfSense (#4671) - Pop!_OS (#3769) - Progate (#3680) - Progress (#4611) - PyPy (#4281) - Racket (#3483) - Radar (#4319) - Rainmeter (#3554) - Reliance Industries Limited (#4702) - Revue (#4391) - ROS (#4658) - SciPy (#3772) - Scrimba (#4556) - SEPA (#3154) - SoloLearn (#4624) - Spark AR (#4468) - Speedtest (#4626) - STARZ (#4612) - Streamlit (#4412) - Swiper (#4562) - São Paulo Metro (#4570) - tado° (#4637) - TaxBuzz (#4619) - Testin (#4571) - Testing Library (#4542) - ThinkPad (#4550) - Ticketmaster (#4526) - Tile (#4614) - tmux (#3512) - Treyarch (#4690) - TrueNAS (#4574) - Unraid (#4613) - UPS (#4565) - USPS (#4549) - Vault (#4606) - Vimeo Livestream (#4703) - Webflow (#4568) - Weights & Biases (#4630) - Wikiquote (#4687) - Winmate (#3316) - Wipro (#4359) - Xilinx (#3424) - Zelle (#4605) - Zoho (#3661) - Zomato (#4664) - Zotero (#4561) # Updated Icons - Adobe XD (#3386) - Amazon Lumberyard (#4591) - Andela (#4592) - Apache Maven (#4593) - Daimler (#4618) - DigitalOcean (#4648) - Fossa (#4473) - Gatsby (#4620) - GIPHY (#4621) - Google (#4508) - Google Analytics (#4504) - Google Cardboard (#4058) - Google Fit (#4506) - Harbor (#4598) - Jira Software (#4657) - Kahoot! (#4635) - Kotlin (#4485) - Kyocera (#4475) - Lenovo (#4477) - Material Design Icons (#4642) - Mozilla (#4656) - pr.co (#4655) - SonicWall (#4654) - StackPath (#4652) - Stadia (#4503) - Synology (#4220) - TED (#4653) - Trustpilot (#4481) - Uber (#4650) - Uber Eats (#4651) - Udacity (#4596) - Viber (#4597) - Waze (#4583) - Wish (#4482) - WP Engine (#4639) - XMPP (#4483) - YouTube (#4582) - YouTube Studio (#4581) - YouTube TV (#4405) - Zendesk (#4595) - Zillow (#4636)
Issue: Closes #3846
Alexa rank: 436
Checklist
_data/simple-icons.json
viewbox
is0 0 24 24
Description
Icon & colour from SVG in website header; I went with the lighter green as they also use if for the buttons on their site. Unfortunately, I had to go with a precision of 4 to prevent SVGO from resizing it.
This PR also removes an unnecessary JPG file that was inadvertently added in #4561