Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Linktree #4662

Merged
merged 4 commits into from
Jan 8, 2021
Merged

Conversation

PeterShaggyNoble
Copy link
Member

@PeterShaggyNoble PeterShaggyNoble commented Jan 7, 2021

Linktree

Issue: Closes #3846
Alexa rank: 436

Checklist

  • I updated the JSON data in _data/simple-icons.json
  • I optimized the icon with SVGO or SVGOMG
  • The SVG viewbox is 0 0 24 24

Description

Icon & colour from SVG in website header; I went with the lighter green as they also use if for the buttons on their site. Unfortunately, I had to go with a precision of 4 to prevent SVGO from resizing it.

This PR also removes an unnecessary JPG file that was inadvertently added in #4561

And remove Zotero JPG
@PeterShaggyNoble PeterShaggyNoble added the new icon Issues or pull requests for adding a new icon label Jan 7, 2021
@fbernhart
Copy link
Contributor

fbernhart commented Jan 7, 2021

Oops ... Sorry, I didn't notice that there was a JPG file added while reviewing #4561. Thanks for pointing out! 🏆

Makes me wondering if we could add a new rule to the linter, that quickly checks if only SVG files are located in the icons folder? @simple-icons/maintainers what do you think?

Some days ago I saw that someone added a LNK file by mistake to their PR. So it seems like stuff like this happens from time to time.

@fbernhart
Copy link
Contributor

@PeterShaggyNoble Here is a path with a precision of 3. Feel free to use it.

<svg role="img" viewBox="0 0 24 24" xmlns="http://www.w3.org/2000/svg"><title>Linktree icon</title><path d="M8.033 1.892a1.065 1.065 0 0 0-.971.547L.102 15.065c-.323.648.161 1.38.89 1.38h4.695v4.772c0 .487.404.892.89.892h2.75a.897.897 0 0 0 .892-.89v-4.775H8.924a1.052 1.052 0 0 1-1.05-.891c0-.162-.001-.325.079-.488l3.884-7.041-2.913-5.585a1.065 1.065 0 0 0-.891-.547zm7.937.003a1.065 1.065 0 0 0-.894.544l-2.995 5.587 3.884 7.039c.082.163.082.326.082.488a1.052 1.052 0 0 1-1.053.891H13.7v4.776a.898.898 0 0 0 .89.889h2.915a.899.899 0 0 0 .891-.892v-4.773h4.611c.729 0 1.215-.73.891-1.38L16.937 2.44a1.065 1.065 0 0 0-.967-.544z"/></svg>

Sometimes it helps resizing the icon to 23.999 or 24.001 instead before optimizing it. And then after the optimization it will be exactly 24.000. 😊

@PeterShaggyNoble
Copy link
Member Author

Thanks, @fbernhart. However, I'm seeing a hairline difference at the bottom of the arrowheads when comparing your version (in red) with the original.

@PeterShaggyNoble
Copy link
Member Author

Makes me wondering if we could add a new rule to the linter, that quickly checks if only SVG files are located in the icons folder?

Yes, no harm in doing that, if it's possible - we've all accidentally pasted the wrong file into the wrong directory at some stage!

@ericcornelissen
Copy link
Contributor

Makes me wondering if we could add a new rule to the linter, that quickly checks if only SVG files are located in the icons folder?

Yes, no harm in doing that, if it's possible - we've all accidentally pasted the wrong file into the wrong directory at some stage!

This could be added fairly easily to the our-lint script using fs.readdir/fs.readdirSync 👍

@service-paradis
Copy link
Member

service-paradis commented Jan 7, 2021

Makes me wondering if we could add a new rule to the linter, that quickly checks if only SVG files are located in the icons folder?

Yes, no harm in doing that, if it's possible - we've all accidentally pasted the wrong file into the wrong directory at some stage!

This could be added fairly easily to the our-lint script using fs.readdir/fs.readdirSync 👍

Maybe we could add a rule in .gitignore too to allow only SVG files.

Something like:

#ignore all kind of files
icons/*
#except SVG files
!*.svg

@adamrusted
Copy link
Member

Makes me wondering if we could add a new rule to the linter, that quickly checks if only SVG files are located in the icons folder?

Yes, no harm in doing that, if it's possible - we've all accidentally pasted the wrong file into the wrong directory at some stage!

This could be added fairly easily to the our-lint script using fs.readdir/fs.readdirSync 👍

Maybe we could add a rule in .gitignore too to allow only SVG files.

Something like:

#ignore all kind of files
icons/*
#except SVG files
!*.svg

My bad! Sorry guys 😅
Obviously very keen to share the Zotero icon!

@ericcornelissen
Copy link
Contributor

Maybe we could add a rule in .gitignore too to allow only SVG files.

Something like:

#ignore all kind of files
icons/*
#except SVG files
!*.svg

Perhaps that is a bit easier yes, not a bad idea! (Theoretically this can be circumvented, in contrast to the linter, but that's not something to worry about). Without the intention of hijacking this PR for this disussion, should this go in the root folder's .gitignore or a separate .gitignore inside the icons directory? 🤔

My bad! Sorry guys sweat_smile
Obviously very keen to share the Zotero icon!

No problem at all, it happens to the best of us 😄

@PeterShaggyNoble
Copy link
Member Author

I'd stick it in the root .gitignore, @ericcornelissen, to keep everything in one place.

@adamrusted
Copy link
Member

@PeterShaggyNoble able to get it down to a precision of 3 by exporting from illustrator with the path being 24.0001px wide and using SVGO. Feel free to use below path:

<svg role="img" viewBox="0 0 24 24" xmlns="http://www.w3.org/2000/svg"><title>Linktree icon</title><path d="M7.953 15.066c-.08.163-.08.324-.08.486.08.517.528.897 1.052.89h1.294v4.776c0 .486-.404.89-.89.89H6.577a.898.898 0 0 1-.889-.891v-4.774H.992c-.728 0-1.214-.729-.89-1.377l6.96-12.627a1.065 1.065 0 0 1 1.863 0l2.913 5.585-3.885 7.042zm15.945 0l-6.96-12.627a1.065 1.065 0 0 0-1.862 0l-2.995 5.586 3.885 7.04c.081.164.081.326.081.487-.08.517-.529.897-1.052.89h-1.296v4.776c.005.49.4.887.89.89h2.914a.9.9 0 0 0 .892-.89v-4.775h4.612c.73 0 1.214-.729.89-1.377z"/></svg>

@PeterShaggyNoble
Copy link
Member Author

PeterShaggyNoble commented Jan 8, 2021

That works, thanks, @adamrusted. Updated.

Copy link
Member

@adamrusted adamrusted left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing, thanks @PeterShaggyNoble! 🔗🌲

@adamrusted adamrusted merged commit 82c6385 into simple-icons:develop Jan 8, 2021
ericcornelissen added a commit that referenced this pull request Jan 10, 2021
# New Icons

- 3M (#3631)
- Accenture (#4396)
- AIOHTTP (#4536)
- AniList (#4609)
- AnyDesk (#4663)
- Apache JMeter (#4594)
- Apache Kylin (#4545)
- ARK Ecosystem (#4699)
- B&amp;R Automation (#4552)
- bigbasket (#4572, #4616)
- Bugcrowd (#4615)
- CheckiO (#4512)
- Chrysler (#4357)
- Cloudways (#3352)
- Cockroach Labs (#4665)
- CodeProject (#4617)
- CodinGame (#4575)
- Cognizant (#4392)
- Contentful (#4537)
- Cookiecutter (#3649)
- DataStax (#4393)
- De'Longhi (#4426)
- Deepnote (#4546)
- Digi-Key Electronics (#4398)
- Eclipse Vert.x (#4631)
- edX (#4452)
- egghead (#4644)
- Eight Sleep (#3638)
- Facepunch (#3671)
- FedEx (#4564)
- Fortran (#4397)
- FreeNAS (#4573)
- Gitee (#4625)
- Google Domains (#4622)
- Google Photos (#4341)
- Grubhub (#4544)
- Homebridge (#4607)
- Hyperledger (#4673)
- IKEA (#4555)
- Ingress (#3389)
- Jitsi (#4540)
- Kitsu (#4520)
- Klook (#4548)
- Lada (#4361)
- Lichess (#3535)
- Linktree (#4662)
- Looker (#4442)
- McLaren (#4538)
- MetaFilter (#4547)
- Motorola (#3425)
- Noun Project (#4608)
- Observable (#4640)
- Open Bug Bounty (#4627)
- Open Nebula (#4551)
- OpenCV (#4580)
- PageSpeed Insights (#4553)
- Paytm (#4643)
- pfSense (#4671)
- Pop!_OS (#3769)
- Progate (#3680)
- Progress (#4611)
- PyPy (#4281)
- Racket (#3483)
- Radar (#4319)
- Rainmeter (#3554)
- Reliance Industries Limited (#4702)
- Revue (#4391)
- ROS (#4658)
- SciPy (#3772)
- Scrimba (#4556)
- SEPA (#3154)
- SoloLearn (#4624)
- Spark AR (#4468)
- Speedtest (#4626)
- STARZ (#4612)
- Streamlit (#4412)
- Swiper (#4562)
- São Paulo Metro (#4570)
- tado° (#4637)
- TaxBuzz (#4619)
- Testin (#4571)
- Testing Library (#4542)
- ThinkPad (#4550)
- Ticketmaster (#4526)
- Tile (#4614)
- tmux (#3512)
- Treyarch (#4690)
- TrueNAS (#4574)
- Unraid (#4613)
- UPS (#4565)
- USPS (#4549)
- Vault (#4606)
- Vimeo Livestream (#4703)
- Webflow (#4568)
- Weights &amp; Biases (#4630)
- Wikiquote (#4687)
- Winmate (#3316)
- Wipro (#4359)
- Xilinx (#3424)
- Zelle (#4605)
- Zoho (#3661)
- Zomato (#4664)
- Zotero (#4561)

# Updated Icons

- Adobe XD (#3386)
- Amazon Lumberyard (#4591)
- Andela (#4592)
- Apache Maven (#4593)
- Daimler (#4618)
- DigitalOcean (#4648)
- Fossa (#4473)
- Gatsby (#4620)
- GIPHY (#4621)
- Google (#4508)
- Google Analytics (#4504)
- Google Cardboard (#4058)
- Google Fit (#4506)
- Harbor (#4598)
- Jira Software (#4657)
- Kahoot! (#4635)
- Kotlin (#4485)
- Kyocera (#4475)
- Lenovo (#4477)
- Material Design Icons (#4642)
- Mozilla (#4656)
- pr.co (#4655)
- SonicWall (#4654)
- StackPath (#4652)
- Stadia (#4503)
- Synology (#4220)
- TED (#4653)
- Trustpilot (#4481)
- Uber (#4650)
- Uber Eats (#4651)
- Udacity (#4596)
- Viber (#4597)
- Waze (#4583)
- Wish (#4482)
- WP Engine (#4639)
- XMPP (#4483)
- YouTube (#4582)
- YouTube Studio (#4581)
- YouTube TV (#4405)
- Zendesk (#4595)
- Zillow (#4636)
@PeterShaggyNoble PeterShaggyNoble deleted the add/linktree branch January 12, 2021 10:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new icon Issues or pull requests for adding a new icon
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Linktree
5 participants