Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Spark AR icon #4468

Merged
merged 5 commits into from
Jan 3, 2021
Merged

Add Spark AR icon #4468

merged 5 commits into from
Jan 3, 2021

Conversation

edizbaha
Copy link
Contributor

@edizbaha edizbaha commented Dec 26, 2020 •
edited
Loading

sparkar (1)

Close #4434
Alexa rank: 6

Checklist

  • I updated the JSON data in _data/simple-icons.json
  • I optimized the icon with SVGO or SVGOMG
  • The SVG viewbox is 0 0 24 24

Description

The color (pink #FF5C83) was chosen because it's the most prominent on the logo and website.
The icon was created from the official logo by me.

@fbernhart fbernhart mentioned this pull request Dec 26, 2020
Closed
3 tasks
fbernhart
fbernhart suggested changes Dec 26, 2020
View reviewed changes
Copy link
Contributor

@fbernhart fbernhart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@edizbaha Thanks for your contribution so far.

However, it seems like you've forgotten to add the SVG file itself to your pull request. Can you change that?

I'm as well wondering if the word "Studio" is really necessary in this case. Wouldn't it be better to just name it "Spark AR"? Seems like Facebook is as well marketing "Spark AR Hub" and "Spark AR Player" with the same icon/logo. So "Spark AR" would represent all of this. What's your opinion?

@edizbaha edizbaha changed the title Added Spark AR Studio icon Added Spark AR icon Dec 27, 2020
@edizbaha edizbaha changed the title Added Spark AR icon Add Spark AR icon Dec 27, 2020
@edizbaha
Copy link
Contributor Author

edizbaha commented Dec 27, 2020 •
edited
Loading

@edizbaha Thanks for your contribution so far.

However, it seems like you've forgotten to add the SVG file itself to your pull request. Can you change that?

I'm as well wondering if the word "Studio" is really necessary in this case. Wouldn't it be better to just name it "Spark AR"? Seems like Facebook is as well marketing "Spark AR Hub" and "Spark AR Player" with the same icon/logo. So "Spark AR" would represent all of this. What's your opinion?

You are right, it would be right to use it as Spark AR. I updated the json file to Spark AR. But I did not fully understand where to add the svg file.

I uploaded the svg file here. Can you download and add it from here? @fbernhart

Svg file link: https://www.mediafire.com/file/857zkpfxcz5ol3r/sparkar.svg/file

@adamrusted adamrusted mentioned this pull request Dec 27, 2020
Closed
@adamrusted
Copy link
Member

@edizbaha - thanks for your contribution!
The icon required a little work to get it to pass the linter (for reference, run npm install then npm run svglint locally to see the results before pushing here) but otherwise is great! I'll wait for another @simple-icons/maintainers to approve this one, being as I've altered the icon somewhat.

@adamrusted adamrusted added the new icon Issues or pull requests for adding a new icon label Dec 27, 2020
@edizbaha
Copy link
Contributor Author

edizbaha commented Jan 3, 2021

When will you review and add this icon on simpleicons.org?
I did as much as I could. I can't do any more.
@fbernhart @adamrusted

@adamrusted
Copy link
Member

When will you review and add this icon on simpleicons.org?
I did as much as I could. I can't do any more.
@fbernhart @adamrusted

I've asked for another reviewer to look at this one, being as I had to make tweaks to the icon, so it's whenever one of the other maintainers can take a look.

The icon looks great, so thanks for your work in this @edizbaha 😁

@edizbaha
Copy link
Contributor Author

edizbaha commented Jan 3, 2021 •
edited
Loading

I've asked for another reviewer to look at this one, being as I had to make tweaks to the icon, so it's whenever one of the other maintainers can take a look.

The icon looks great, so thanks for your work in this @edizbaha 😁

Thanks, I hope another reviewer to look at this icon. 😊

@mondeja
Copy link
Member

mondeja commented Jan 3, 2021

🤔 Shouldn't this icon include spaces between colors @adamrusted?

@adamrusted
Copy link
Member

🤔 Shouldn't this icon include spaces between colors @adamrusted?

Yep - just committed 😅

mondeja
mondeja requested changes Jan 3, 2021
View reviewed changes
Copy link
Member

@mondeja mondeja left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just for consistency, could you remove these two coordinates that are almost collinear?

image

@adamrusted
Copy link
Member

@mondeja done! 😁

mondeja
mondeja approved these changes Jan 3, 2021
View reviewed changes
Copy link
Member

@mondeja mondeja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect 💯
Thank you @edizbaha and @adamrusted for your work 🙏

@mondeja mondeja merged commit c5565be into simple-icons:develop Jan 3, 2021
@edizbaha
Copy link
Contributor Author

edizbaha commented Jan 4, 2021

Thank you for your work. @adamrusted 😊

@github-actions github-actions bot mentioned this pull request Jan 10, 2021
Merged
ericcornelissen added a commit that referenced this pull request Jan 10, 2021
@ericcornelissen
Release 103 new icons and 41 updated icons (v4.6.0)
701d605 
# New Icons

- 3M (#3631)
- Accenture (#4396)
- AIOHTTP (#4536)
- AniList (#4609)
- AnyDesk (#4663)
- Apache JMeter (#4594)
- Apache Kylin (#4545)
- ARK Ecosystem (#4699)
- B&R Automation (#4552)
- bigbasket (#4572, #4616)
- Bugcrowd (#4615)
- CheckiO (#4512)
- Chrysler (#4357)
- Cloudways (#3352)
- Cockroach Labs (#4665)
- CodeProject (#4617)
- CodinGame (#4575)
- Cognizant (#4392)
- Contentful (#4537)
- Cookiecutter (#3649)
- DataStax (#4393)
- De'Longhi (#4426)
- Deepnote (#4546)
- Digi-Key Electronics (#4398)
- Eclipse Vert.x (#4631)
- edX (#4452)
- egghead (#4644)
- Eight Sleep (#3638)
- Facepunch (#3671)
- FedEx (#4564)
- Fortran (#4397)
- FreeNAS (#4573)
- Gitee (#4625)
- Google Domains (#4622)
- Google Photos (#4341)
- Grubhub (#4544)
- Homebridge (#4607)
- Hyperledger (#4673)
- IKEA (#4555)
- Ingress (#3389)
- Jitsi (#4540)
- Kitsu (#4520)
- Klook (#4548)
- Lada (#4361)
- Lichess (#3535)
- Linktree (#4662)
- Looker (#4442)
- McLaren (#4538)
- MetaFilter (#4547)
- Motorola (#3425)
- Noun Project (#4608)
- Observable (#4640)
- Open Bug Bounty (#4627)
- Open Nebula (#4551)
- OpenCV (#4580)
- PageSpeed Insights (#4553)
- Paytm (#4643)
- pfSense (#4671)
- Pop!_OS (#3769)
- Progate (#3680)
- Progress (#4611)
- PyPy (#4281)
- Racket (#3483)
- Radar (#4319)
- Rainmeter (#3554)
- Reliance Industries Limited (#4702)
- Revue (#4391)
- ROS (#4658)
- SciPy (#3772)
- Scrimba (#4556)
- SEPA (#3154)
- SoloLearn (#4624)
- Spark AR (#4468)
- Speedtest (#4626)
- STARZ (#4612)
- Streamlit (#4412)
- Swiper (#4562)
- São Paulo Metro (#4570)
- tado° (#4637)
- TaxBuzz (#4619)
- Testin (#4571)
- Testing Library (#4542)
- ThinkPad (#4550)
- Ticketmaster (#4526)
- Tile (#4614)
- tmux (#3512)
- Treyarch (#4690)
- TrueNAS (#4574)
- Unraid (#4613)
- UPS (#4565)
- USPS (#4549)
- Vault (#4606)
- Vimeo Livestream (#4703)
- Webflow (#4568)
- Weights & Biases (#4630)
- Wikiquote (#4687)
- Winmate (#3316)
- Wipro (#4359)
- Xilinx (#3424)
- Zelle (#4605)
- Zoho (#3661)
- Zomato (#4664)
- Zotero (#4561)

# Updated Icons

- Adobe XD (#3386)
- Amazon Lumberyard (#4591)
- Andela (#4592)
- Apache Maven (#4593)
- Daimler (#4618)
- DigitalOcean (#4648)
- Fossa (#4473)
- Gatsby (#4620)
- GIPHY (#4621)
- Google (#4508)
- Google Analytics (#4504)
- Google Cardboard (#4058)
- Google Fit (#4506)
- Harbor (#4598)
- Jira Software (#4657)
- Kahoot! (#4635)
- Kotlin (#4485)
- Kyocera (#4475)
- Lenovo (#4477)
- Material Design Icons (#4642)
- Mozilla (#4656)
- pr.co (#4655)
- SonicWall (#4654)
- StackPath (#4652)
- Stadia (#4503)
- Synology (#4220)
- TED (#4653)
- Trustpilot (#4481)
- Uber (#4650)
- Uber Eats (#4651)
- Udacity (#4596)
- Viber (#4597)
- Waze (#4583)
- Wish (#4482)
- WP Engine (#4639)
- XMPP (#4483)
- YouTube (#4582)
- YouTube Studio (#4581)
- YouTube TV (#4405)
- Zendesk (#4595)
- Zillow (#4636)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mondeja mondeja mondeja approved these changes

@fbernhart fbernhart Awaiting requested review from fbernhart

Assignees
No one assigned
Labels
new icon Issues or pull requests for adding a new icon
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Request: Spark AR Studio İcon
5 participants
@edizbaha @adamrusted @mondeja @fbernhart @ericcornelissen