Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Synology #4220

Merged
merged 6 commits into from
Jan 3, 2021
Merged

Update Synology #4220

merged 6 commits into from
Jan 3, 2021

Conversation

fbernhart
Copy link
Contributor

synology

Issue: #3169
Alexa rank: -

Checklist

  • I updated the JSON data in _data/simple-icons.json --> (wasn't necessary)
  • I optimized the icon with SVGO or SVGOMG
  • The SVG viewbox is 0 0 24 24

Description

I took the already used SVG.
I used Inkscape to fix size and center
I used https://jakearchibald.github.io/svgomg/ to optimize the resulting SVG

@github-actions github-actions bot added the update icon/data Issues or pull requests regarding icons that are outdated, this can be the SVG or color or both label Dec 2, 2020
@fbernhart fbernhart mentioned this pull request Dec 2, 2020
Closed
adamrusted
adamrusted reviewed Dec 27, 2020
View reviewed changes
Copy link
Member

@adamrusted adamrusted left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be updated to the full wordmark, as shown on their logo guide?
What do other @simple-icons/maintainers think?

@adamrusted adamrusted added the awaiting reply Issues or pull requests awaiting reply from an individual before it may be addressed label Dec 27, 2020
@mondeja
Copy link
Member

mondeja commented Dec 27, 2020

Should this be updated to the full wordmark, as shown on their logo guide?

I would say yes, quoting brand guidelines: 'The "Synology" logo consists of the word Synology as illustrated below.'

@mondeja mondeja removed the awaiting reply Issues or pull requests awaiting reply from an individual before it may be addressed label Dec 27, 2020
adamrusted
adamrusted requested changes Dec 28, 2020
View reviewed changes
Copy link
Member

@adamrusted adamrusted left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be updated to the full wordmark, as shown on their logo guide?

I would say yes, quoting brand guidelines: 'The "Synology" logo consists of the word Synology as illustrated below.'

@fbernhart - as mentioned above, could you please regenerate this using the full wordmark for Synology? 🙏🏻

@fbernhart
Copy link
Contributor Author

fbernhart commented Dec 29, 2020 •
edited
Loading

@adamrusted Done. I've as well changed the color slightly. Their brand guidelines mention rgb(181,181,182) which should be #B5B5B6.

synology

@adamrusted
Copy link
Member

@adamrusted Done. I've as well changed the color slightly. Their brand guidelines mention rgb(181,181,182) which should be #B5B5B6.

Amazing - do we need to include the ® symbol in the logo also? I don't see any explicit mention on the logo guide page about the mark, but it is featured in every use of the logo on the page, even the incorrect ones!

@fbernhart
Copy link
Contributor Author

Amazing - do we need to include the ® symbol in the logo also?

@adamrusted Quoting our contribution guidelines:

If there is no explicit requirement that a symbol must be included, it must not be included.

That's why I've removed it.

@ericcornelissen
Copy link
Contributor

I'm not familiar with the brand, but from the brand guidelines this seems to me to fall into the same category as Intel 🤔

If the symbol is incorporated into the design of the logo (e.g. Intel), it must be included.

@fbernhart
Copy link
Contributor Author

I wouldn't say that the (R) is really integrated into the design of the logo.

But I'm happy to add it, if this is the consensus. 😊

@ericcornelissen
Copy link
Contributor

I wouldn't say that the (R) is really integrated into the design of the logo.

If it isn't can you show me a place where they use the logo without the (R)?

@fbernhart
Copy link
Contributor Author

You're right. Seems like they are using it everywhere.

Let me add it. 👍🏼

@fbernhart
Copy link
Contributor Author

Fixed

synology

adamrusted
adamrusted approved these changes Jan 3, 2021
View reviewed changes
Copy link
Member

@adamrusted adamrusted left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect! @fbernhart 💯

@adamrusted adamrusted merged commit fb2fca6 into simple-icons:develop Jan 3, 2021
@fbernhart fbernhart deleted the Synology branch January 3, 2021 17:31
@github-actions github-actions bot mentioned this pull request Jan 10, 2021
Merged
ericcornelissen added a commit that referenced this pull request Jan 10, 2021
@ericcornelissen
Release 103 new icons and 41 updated icons (v4.6.0)
701d605 
# New Icons

- 3M (#3631)
- Accenture (#4396)
- AIOHTTP (#4536)
- AniList (#4609)
- AnyDesk (#4663)
- Apache JMeter (#4594)
- Apache Kylin (#4545)
- ARK Ecosystem (#4699)
- B&R Automation (#4552)
- bigbasket (#4572, #4616)
- Bugcrowd (#4615)
- CheckiO (#4512)
- Chrysler (#4357)
- Cloudways (#3352)
- Cockroach Labs (#4665)
- CodeProject (#4617)
- CodinGame (#4575)
- Cognizant (#4392)
- Contentful (#4537)
- Cookiecutter (#3649)
- DataStax (#4393)
- De'Longhi (#4426)
- Deepnote (#4546)
- Digi-Key Electronics (#4398)
- Eclipse Vert.x (#4631)
- edX (#4452)
- egghead (#4644)
- Eight Sleep (#3638)
- Facepunch (#3671)
- FedEx (#4564)
- Fortran (#4397)
- FreeNAS (#4573)
- Gitee (#4625)
- Google Domains (#4622)
- Google Photos (#4341)
- Grubhub (#4544)
- Homebridge (#4607)
- Hyperledger (#4673)
- IKEA (#4555)
- Ingress (#3389)
- Jitsi (#4540)
- Kitsu (#4520)
- Klook (#4548)
- Lada (#4361)
- Lichess (#3535)
- Linktree (#4662)
- Looker (#4442)
- McLaren (#4538)
- MetaFilter (#4547)
- Motorola (#3425)
- Noun Project (#4608)
- Observable (#4640)
- Open Bug Bounty (#4627)
- Open Nebula (#4551)
- OpenCV (#4580)
- PageSpeed Insights (#4553)
- Paytm (#4643)
- pfSense (#4671)
- Pop!_OS (#3769)
- Progate (#3680)
- Progress (#4611)
- PyPy (#4281)
- Racket (#3483)
- Radar (#4319)
- Rainmeter (#3554)
- Reliance Industries Limited (#4702)
- Revue (#4391)
- ROS (#4658)
- SciPy (#3772)
- Scrimba (#4556)
- SEPA (#3154)
- SoloLearn (#4624)
- Spark AR (#4468)
- Speedtest (#4626)
- STARZ (#4612)
- Streamlit (#4412)
- Swiper (#4562)
- São Paulo Metro (#4570)
- tado° (#4637)
- TaxBuzz (#4619)
- Testin (#4571)
- Testing Library (#4542)
- ThinkPad (#4550)
- Ticketmaster (#4526)
- Tile (#4614)
- tmux (#3512)
- Treyarch (#4690)
- TrueNAS (#4574)
- Unraid (#4613)
- UPS (#4565)
- USPS (#4549)
- Vault (#4606)
- Vimeo Livestream (#4703)
- Webflow (#4568)
- Weights & Biases (#4630)
- Wikiquote (#4687)
- Winmate (#3316)
- Wipro (#4359)
- Xilinx (#3424)
- Zelle (#4605)
- Zoho (#3661)
- Zomato (#4664)
- Zotero (#4561)

# Updated Icons

- Adobe XD (#3386)
- Amazon Lumberyard (#4591)
- Andela (#4592)
- Apache Maven (#4593)
- Daimler (#4618)
- DigitalOcean (#4648)
- Fossa (#4473)
- Gatsby (#4620)
- GIPHY (#4621)
- Google (#4508)
- Google Analytics (#4504)
- Google Cardboard (#4058)
- Google Fit (#4506)
- Harbor (#4598)
- Jira Software (#4657)
- Kahoot! (#4635)
- Kotlin (#4485)
- Kyocera (#4475)
- Lenovo (#4477)
- Material Design Icons (#4642)
- Mozilla (#4656)
- pr.co (#4655)
- SonicWall (#4654)
- StackPath (#4652)
- Stadia (#4503)
- Synology (#4220)
- TED (#4653)
- Trustpilot (#4481)
- Uber (#4650)
- Uber Eats (#4651)
- Udacity (#4596)
- Viber (#4597)
- Waze (#4583)
- Wish (#4482)
- WP Engine (#4639)
- XMPP (#4483)
- YouTube (#4582)
- YouTube Studio (#4581)
- YouTube TV (#4405)
- Zendesk (#4595)
- Zillow (#4636)
@krisu5 krisu5 mentioned this pull request Apr 26, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adamrusted adamrusted adamrusted approved these changes

Assignees
No one assigned
Labels
update icon/data Issues or pull requests regarding icons that are outdated, this can be the SVG or color or both
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@fbernhart @mondeja @adamrusted @ericcornelissen