Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add cookiecutter icon #3649

Merged
merged 7 commits into from
Jan 8, 2021
Merged

Add cookiecutter icon #3649

merged 7 commits into from
Jan 8, 2021

Conversation

browniebroke
Copy link
Contributor

@browniebroke browniebroke commented Oct 4, 2020 •
edited

cookiecutter-preview

Issue:
Alexa rank:

Checklist

  • I updated the JSON data in _data/simple-icons.json
  • I optimized the icon with SVGO or SVGOMG
  • The SVG viewbox is 0 0 24 24

Description

I'm helping maintain a popular cookiecutter template (Cookiecutter Django) and I was interested in adding the logo to a custom shield.io badge.

So far, I've managed to add the image base64 encoded:
cookiecutter

But I'm interested to add the image here to make it easier (since shied.io uses simple icons as source).

@browniebroke browniebroke deleted the cookiecutter branch October 4, 2020 17:47
@browniebroke browniebroke restored the cookiecutter branch October 4, 2020 17:47
@PeterShaggyNoble
Copy link
Member

Did you mean to close this, @browniebroke, or are you still working on it?

@PeterShaggyNoble PeterShaggyNoble added new icon Issues or pull requests for adding a new icon abandoned Pull requests that have been abandoned by the contributor labels Jan 6, 2021
@browniebroke
Copy link
Contributor Author

I'm no longer working on this. I worked from a PNG and tried to generate a SVG, but it didn't work and it seems out of my skill sets.

I can share the Figma file if someone is interested to pick it up...

@PeterShaggyNoble
Copy link
Member

There's an SVG at https://github.com/cookiecutter/cookiecutter/blob/master/logo/cookiecutter-logo.svg if you'd like to give it another go?

@browniebroke browniebroke reopened this Jan 6, 2021
@browniebroke
Copy link
Contributor Author

I think the main problem left is that the SVG makes use of fill-rule="evenodd". If I run it through SVGO, the attribute is stripped and the eye disappear.

@adamrusted
Copy link
Member

Hey @browniebroke, I can see you're having a few issues getting the linter to pass.
I've been able to generate the below path, which passed the linter - feel free to use it 👌🏻

<svg role="img" xmlns="http://www.w3.org/2000/svg" viewBox="0 0 24 24"><title>Cookiecutter icon</title><path d="M12.8182 12l9.2432-7.6496a11.9972 11.9972 0 00-3.1978-2.7141C13.14-1.7025 5.7933.2308 2.4545 5.9545-.8843 11.6782 1.049 19.0248 6.7727 22.3636s13.0703 1.4055 16.4091-4.3182L12.8182 12zm-6.7579 1.406c-.365 0-.7272-.1657-.8049-.3682-.0777-.2025.1177-.9702.4342-1.706.5056-1.1753.6693-1.3378 1.3478-1.3378 1.0326 0 1.7876.4344 1.7876 1.0285.0001.6937-1.9602 2.3835-2.7647 2.3835zm4.7117-9.6078c-.4867.1868-2.4566.177-2.9312-.0145-.5264-.2124-.38-.7816.3188-1.2395.8054-.5277 1.2687-.5325 2.2532-.0234.8464.4376 1.0121 1.0269.3592 1.2774zm1.4304 3.037c.3594-.6161 1.1502-.8242 1.7663-.4648.6004.3502.8159 1.1128.4876 1.7255-.3434.6435-1.1596.8746-1.7891.5056-.6161-.3594-.8242-1.1502-.4648-1.7663zM16.859 21.955c-.201.5239-1.0451.4669-1.563-.1054-.676-.7469-.4044-2.6695.377-2.6695.3721 0 1.362 2.3162 1.186 2.7749z"/></svg>

Other @simple-icons/maintainers - the precision of 4 is necessary for the circle to display correctly, unless @fbernhart can work his Inkscape magic again 😅

Use SVG suggested in CR
65d10f5 
Co-Authored-By: Adam Rusted <hello@adamrusted.me>
@browniebroke
Copy link
Contributor Author

Thanks a lot @adamrusted, your trick seems to made it (whatever it was 😄).

I've updated the content and PR description. Do you want me to squash the commits?

@browniebroke browniebroke marked this pull request as ready for review January 6, 2021 14:59
@adamrusted
Copy link
Member

I've updated the content and PR description. Do you want me to squash the commits?

Fab - I'll wait for another @simple-icons/maintainers to merge it being as I worked on the path. We'll squash and merge when it's added, so no need to worry on your end. Thanks for your work on this! 🎉

@adamrusted adamrusted removed the abandoned Pull requests that have been abandoned by the contributor label Jan 6, 2021
@fbernhart
Copy link
Contributor

I did some magic and converted it to a precision of 3. 🧙🏼‍♂️ ✨ 🔮 I've as well updated the source to point to the specific SVG file used.

@adamrusted Feel free to review and merge.

adamrusted
adamrusted approved these changes Jan 8, 2021
View reviewed changes
Copy link
Member

@adamrusted adamrusted left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Thanks @browniebroke for your work on this, and thanks to @fbernhart for your Inkscape Wizardry! 🧙🏻‍♂️🔮

@adamrusted adamrusted merged commit 83456fb into simple-icons:develop Jan 8, 2021
@browniebroke browniebroke deleted the cookiecutter branch January 8, 2021 13:20
@github-actions github-actions bot mentioned this pull request Jan 10, 2021
Merged
ericcornelissen added a commit that referenced this pull request Jan 10, 2021
@ericcornelissen
Release 103 new icons and 41 updated icons (v4.6.0)
701d605 
# New Icons

- 3M (#3631)
- Accenture (#4396)
- AIOHTTP (#4536)
- AniList (#4609)
- AnyDesk (#4663)
- Apache JMeter (#4594)
- Apache Kylin (#4545)
- ARK Ecosystem (#4699)
- B&amp;R Automation (#4552)
- bigbasket (#4572, #4616)
- Bugcrowd (#4615)
- CheckiO (#4512)
- Chrysler (#4357)
- Cloudways (#3352)
- Cockroach Labs (#4665)
- CodeProject (#4617)
- CodinGame (#4575)
- Cognizant (#4392)
- Contentful (#4537)
- Cookiecutter (#3649)
- DataStax (#4393)
- De'Longhi (#4426)
- Deepnote (#4546)
- Digi-Key Electronics (#4398)
- Eclipse Vert.x (#4631)
- edX (#4452)
- egghead (#4644)
- Eight Sleep (#3638)
- Facepunch (#3671)
- FedEx (#4564)
- Fortran (#4397)
- FreeNAS (#4573)
- Gitee (#4625)
- Google Domains (#4622)
- Google Photos (#4341)
- Grubhub (#4544)
- Homebridge (#4607)
- Hyperledger (#4673)
- IKEA (#4555)
- Ingress (#3389)
- Jitsi (#4540)
- Kitsu (#4520)
- Klook (#4548)
- Lada (#4361)
- Lichess (#3535)
- Linktree (#4662)
- Looker (#4442)
- McLaren (#4538)
- MetaFilter (#4547)
- Motorola (#3425)
- Noun Project (#4608)
- Observable (#4640)
- Open Bug Bounty (#4627)
- Open Nebula (#4551)
- OpenCV (#4580)
- PageSpeed Insights (#4553)
- Paytm (#4643)
- pfSense (#4671)
- Pop!_OS (#3769)
- Progate (#3680)
- Progress (#4611)
- PyPy (#4281)
- Racket (#3483)
- Radar (#4319)
- Rainmeter (#3554)
- Reliance Industries Limited (#4702)
- Revue (#4391)
- ROS (#4658)
- SciPy (#3772)
- Scrimba (#4556)
- SEPA (#3154)
- SoloLearn (#4624)
- Spark AR (#4468)
- Speedtest (#4626)
- STARZ (#4612)
- Streamlit (#4412)
- Swiper (#4562)
- São Paulo Metro (#4570)
- tado° (#4637)
- TaxBuzz (#4619)
- Testin (#4571)
- Testing Library (#4542)
- ThinkPad (#4550)
- Ticketmaster (#4526)
- Tile (#4614)
- tmux (#3512)
- Treyarch (#4690)
- TrueNAS (#4574)
- Unraid (#4613)
- UPS (#4565)
- USPS (#4549)
- Vault (#4606)
- Vimeo Livestream (#4703)
- Webflow (#4568)
- Weights &amp; Biases (#4630)
- Wikiquote (#4687)
- Winmate (#3316)
- Wipro (#4359)
- Xilinx (#3424)
- Zelle (#4605)
- Zoho (#3661)
- Zomato (#4664)
- Zotero (#4561)

# Updated Icons

- Adobe XD (#3386)
- Amazon Lumberyard (#4591)
- Andela (#4592)
- Apache Maven (#4593)
- Daimler (#4618)
- DigitalOcean (#4648)
- Fossa (#4473)
- Gatsby (#4620)
- GIPHY (#4621)
- Google (#4508)
- Google Analytics (#4504)
- Google Cardboard (#4058)
- Google Fit (#4506)
- Harbor (#4598)
- Jira Software (#4657)
- Kahoot! (#4635)
- Kotlin (#4485)
- Kyocera (#4475)
- Lenovo (#4477)
- Material Design Icons (#4642)
- Mozilla (#4656)
- pr.co (#4655)
- SonicWall (#4654)
- StackPath (#4652)
- Stadia (#4503)
- Synology (#4220)
- TED (#4653)
- Trustpilot (#4481)
- Uber (#4650)
- Uber Eats (#4651)
- Udacity (#4596)
- Viber (#4597)
- Waze (#4583)
- Wish (#4482)
- WP Engine (#4639)
- XMPP (#4483)
- YouTube (#4582)
- YouTube Studio (#4581)
- YouTube TV (#4405)
- Zendesk (#4595)
- Zillow (#4636)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adamrusted adamrusted adamrusted approved these changes

Assignees
No one assigned
Labels
new icon Issues or pull requests for adding a new icon
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@browniebroke @PeterShaggyNoble @adamrusted @fbernhart